Bug: Types incorrectly identified as missing dependencies for [email protected] with @typescript-eslint/[email protected]

[ifiokjr]

React version: 16.13.1 (although this is related to the eslint plugin).

Steps To Reproduce

1. Install [email protected] with @typescript-eslint/[email protected] in a TypeScript project.
2. Within your hook define a type, or cast a value to a certain type`

   const actions = useMemo(
   	() => bindActionCreators(MultishiftActions, dispatch) as Partial<Item>,
   	[dispatch],
   );

3. eslint-plugin-react-hooks responds with this error React Hook useMemo has a missing dependency: Item. Either include it or remove the dependency array.

Link to code example: remirror/remirror/pull/619

• Checkout the remirror codebase

   git clone https://github.com/remirror/remirror
   git checkout typedoc

• Install the dependencies with pnpm. To setup pnpm run npm i -g pnpm.
• Run the command pnpm run lint:es to lint the codebase.

The current behavior

Types are identified as missing dependencies within a hook and CI fails.

The expected behavior

Types shouldn't be identified as missing dependencies.

[neocturne]

This issue was introduced with @typescript-eslint/parser 4.0.0.

[ifiokjr]

Thanks for the information. I'll update the details. Should I move this to the typescript-eslint repo?

[neocturne]

Thanks for the information. I'll update the details. Should I move this to the typescript-eslint repo?

No, I already asked there, it will need to be fixed up in the react plugin. I have a fix locally, will send a PR in a moment.

[gaearon]

[email protected] should have the fix.

[alecmolloy]

thanks!

[dgattey]

I'm on [email protected] and I'm still seeing this when using a generic value inside a callback. Why might that be? I'm getting React Hook useCallback has a missing dependency: 'Value'. Either include it or remove the dependency array react-hooks/exhaustive-deps with const data: Value = JSON.parse(decompressedValue); as the line that causes the error.