Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn linc should also lint untracked files #11646

Closed
gaearon opened this issue Nov 23, 2017 · 5 comments
Closed

yarn linc should also lint untracked files #11646

gaearon opened this issue Nov 23, 2017 · 5 comments
Labels
Component: Build Infrastructure good first issue (taken)

Comments

@gaearon
Copy link
Collaborator

gaearon commented Nov 23, 2017

Too often I would run yarn linc, it would say lint passed for changed files, and then I'd realize I have not added a file yet so it doesn't see the file.

We should make yarn linc include untracked files. Note that if a file is ignored in git that's a different matter. But if it shows up as untracked it's extremely likely I want to lint it.
@accordeiro
Copy link
Contributor

Hi! Can I help with this one? :)

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 23, 2017

Sure!

@accordeiro
Copy link
Contributor

Cool – I'll work on this and send a PR until this weekend.

accordeiro added a commit to accordeiro/react that referenced this issue Nov 26, 2017
@accordeiro
Lint untracked files with yarn linc (facebook#11646)
a2c5a0e
@accordeiro accordeiro mentioned this issue Nov 26, 2017
Merged
@accordeiro
Copy link
Contributor

Just sent a PR – please let me know if this is what you were looking for :)

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 27, 2017

Fixed in #11665.

@gaearon gaearon closed this as completed Nov 27, 2017
gaearon pushed a commit that referenced this issue Nov 27, 2017
@accordeiro @gaearon
Lint untracked files with yarn linc (#11665)
158f040 
* Lint untracked files with yarn linc (#11646)

* Run prettier on untracked files

* Unify code for listing changed files into shared utility
@snyk-bot snyk-bot mentioned this issue Dec 30, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jan 21, 2022
Open
@snyk-bot snyk-bot mentioned this issue Nov 26, 2022
Open
@snyk-bot snyk-bot mentioned this issue Dec 21, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 23, 2023
Open
@CVSpook CVSpook mentioned this issue May 24, 2023
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this issue Jul 4, 2023
Open
@jackromo888 jackromo888 mentioned this issue Jul 5, 2023
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this issue Oct 1, 2023
Open
@xotik33 xotik33 mentioned this issue Oct 2, 2023
Open
@CVSpook CVSpook mentioned this issue Oct 2, 2023
Open
@DevProp DevProp mentioned this issue Oct 11, 2023
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this issue Nov 26, 2023
Open
@DevProp DevProp mentioned this issue Nov 27, 2023
Open
@xotik33 xotik33 mentioned this issue Nov 28, 2023
Open
@CVSpook CVSpook mentioned this issue Nov 30, 2023
Open
@DevProp DevProp mentioned this issue Dec 15, 2023
Open
This was referenced Dec 30, 2023
Open
Open
@DevProp DevProp mentioned this issue Jan 1, 2024
Open
@xotik33 xotik33 mentioned this issue Jan 9, 2024
Open
@DevProp DevProp mentioned this issue Jan 9, 2024
Open
@CVSpook CVSpook mentioned this issue Jan 9, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this issue Jan 9, 2024
Open
@CVSpook CVSpook mentioned this issue Jan 30, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this issue Feb 11, 2024
Open
@CVSpook CVSpook mentioned this issue Feb 11, 2024
Open
@xotik33 xotik33 mentioned this issue Feb 12, 2024
Open
@DevProp DevProp mentioned this issue Feb 12, 2024
Open
@xotik33 xotik33 mentioned this issue Mar 22, 2024
Open
@CVSpook CVSpook mentioned this issue Mar 22, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this issue Mar 22, 2024
Open
@DevProp DevProp mentioned this issue Mar 22, 2024
Open
This was referenced Apr 5, 2024
Open
Open
@DevProp DevProp mentioned this issue May 13, 2024
Open
@CVSpook CVSpook mentioned this issue May 13, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this issue May 13, 2024
Open
@xotik33 xotik33 mentioned this issue May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Build Infrastructure good first issue (taken)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @accordeiro