Fixed goofy short-circuit bug

facebook · Aug 3, 2021 · fc07195 · fc07195
1 parent cd3b12e
commit fc07195
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/packages/react-devtools-scheduling-profiler/src/content-views/ComponentMeasuresView.js b/packages/react-devtools-scheduling-profiler/src/content-views/ComponentMeasuresView.js
@@ -71,12 +71,12 @@ export class ComponentMeasuresView extends View {
   _drawSingleReactComponentMeasure(
     context: CanvasRenderingContext2D,
     rect: Rect,
-    event: ReactComponentMeasure,
+    componentMeasure: ReactComponentMeasure,
     scaleFactor: number,
     showHoverHighlight: boolean,
   ): boolean {
     const {frame} = this;
-    const {componentName, duration, timestamp, warning} = event;
+    const {componentName, duration, timestamp, warning} = componentMeasure;
 
     const xStart = timestampToPosition(timestamp, scaleFactor, frame);
     const xStop = timestampToPosition(timestamp + duration, scaleFactor, frame);
@@ -146,14 +146,13 @@ export class ComponentMeasuresView extends View {
     let didDrawMeasure = false;
     componentMeasures.forEach(componentMeasure => {
       didDrawMeasure =
-        didDrawMeasure ||
         this._drawSingleReactComponentMeasure(
           context,
           visibleArea,
           componentMeasure,
           scaleFactor,
           componentMeasure === _hoveredComponentMeasure,
-        );
+        ) || didDrawMeasure;
     });
 
     if (!didDrawMeasure) {