Clear more Fiber fields in detachFiber (#18556)

facebook · Apr 9, 2020 · d48dbb8 · d48dbb8
1 parent 0566b70
commit d48dbb8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -1118,6 +1118,7 @@ function detachFiber(fiber: Fiber) {
   // itself will be GC:ed when the parent updates the next time.
   fiber.return = null;
   fiber.child = null;
+  fiber.sibling = null;
   fiber.memoizedState = null;
   fiber.updateQueue = null;
   fiber.dependencies = null;
@@ -1127,6 +1128,9 @@ function detachFiber(fiber: Fiber) {
   fiber.pendingProps = null;
   fiber.memoizedProps = null;
   fiber.stateNode = null;
+  if (__DEV__) {
+    fiber._debugOwner = null;
+  }
 }
 
 function emptyPortalContainer(current: Fiber) {

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js
@@ -1118,6 +1118,7 @@ function detachFiber(fiber: Fiber) {
   // itself will be GC:ed when the parent updates the next time.
   fiber.return = null;
   fiber.child = null;
+  fiber.sibling = null;
   fiber.memoizedState = null;
   fiber.updateQueue = null;
   fiber.dependencies = null;
@@ -1127,6 +1128,9 @@ function detachFiber(fiber: Fiber) {
   fiber.pendingProps = null;
   fiber.memoizedProps = null;
   fiber.stateNode = null;
+  if (__DEV__) {
+    fiber._debugOwner = null;
+  }
 }
 
 function emptyPortalContainer(current: Fiber) {