Rename isListener to isDocListener in ReactBrowserEventEmitter

Now that the ReactBrowserEventEmitter handles local event attachment, it can otherwise be confusing what the `isListening` variable describes.
facebook · Apr 7, 2017 · c94c846 · c94c846
1 parent 7a64e48
commit c94c846
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/renderers/dom/shared/ReactBrowserEventEmitter.js b/src/renderers/dom/shared/ReactBrowserEventEmitter.js
@@ -260,7 +260,7 @@ var ReactBrowserEventEmitter = Object.assign({}, ReactEventEmitterMixin, {
    */
   listenTo: function(registrationName, contentDocumentHandle, node) {
     var mountAt = contentDocumentHandle;
-    var isListening = getListeningForDocument(mountAt);
+    var isDocListening = getListeningForDocument(mountAt);
     var dependencies = EventPluginRegistry.registrationNameDependencies[
       registrationName
     ];
@@ -297,7 +297,7 @@ var ReactBrowserEventEmitter = Object.assign({}, ReactEventEmitterMixin, {
           );
         }
       } else if (
-        !(isListening.hasOwnProperty(dependency) && isListening[dependency])
+        !(isDocListening.hasOwnProperty(dependency) && isDocListening[dependency])
       ) {
         if (dependency === 'topScroll') {
           ReactBrowserEventEmitter.ReactEventListener.trapCapturedEvent(
@@ -318,8 +318,8 @@ var ReactBrowserEventEmitter = Object.assign({}, ReactEventEmitterMixin, {
           );
 
           // to make sure blur and focus event listeners are only attached once
-          isListening.topBlur = true;
-          isListening.topFocus = true;
+          isDocListening.topBlur = true;
+          isDocListening.topFocus = true;
         } else if (dependency === 'topCancel') {
           if (isEventSupported('cancel', true)) {
             ReactBrowserEventEmitter.ReactEventListener.trapCapturedEvent(
@@ -328,7 +328,7 @@ var ReactBrowserEventEmitter = Object.assign({}, ReactEventEmitterMixin, {
               mountAt,
             );
           }
-          isListening.topCancel = true;
+          isDocListening.topCancel = true;
         } else if (dependency === 'topClose') {
           if (isEventSupported('close', true)) {
             ReactBrowserEventEmitter.ReactEventListener.trapCapturedEvent(
@@ -337,7 +337,7 @@ var ReactBrowserEventEmitter = Object.assign({}, ReactEventEmitterMixin, {
               mountAt,
             );
           }
-          isListening.topClose = true;
+          isDocListening.topClose = true;
         } else if (topEventMapping.hasOwnProperty(dependency)) {
           ReactBrowserEventEmitter.ReactEventListener.trapBubbledEvent(
             dependency,
@@ -346,20 +346,20 @@ var ReactBrowserEventEmitter = Object.assign({}, ReactEventEmitterMixin, {
           );
         }
 
-        isListening[dependency] = true;
+        isDocListening[dependency] = true;
       }
     }
   },
 
   isListeningToAllDependencies: function(registrationName, mountAt) {
-    var isListening = getListeningForDocument(mountAt);
+    var isDocListening = getListeningForDocument(mountAt);
     var dependencies = EventPluginRegistry.registrationNameDependencies[
       registrationName
     ];
     for (var i = 0; i < dependencies.length; i++) {
       var dependency = dependencies[i];
       if (
-        !(isListening.hasOwnProperty(dependency) && isListening[dependency])
+        !(isDocListening.hasOwnProperty(dependency) && isDocListening[dependency])
       ) {
         return false;
       }