[eslint] Add an option to require dependencies on effect hooks (#33344)

Summary:

To prepare for automatic effect dependencies, some codebases may want to
codemod
existing useEffect calls with no deps to include an explicit undefined
second argument
in order to preserve the "run on every render" behavior. In sufficiently
large codebases,
this may require a temporary enforcement period where all effects
provide an explicit
dependencies argument.

Outside of migration, relying on a component to render can lead to real
bugs,
especially when working with memoization.

DiffTrain build for [99efc62](99efc62)

Author: jbrown215

compiled/eslint-plugin-react-hooks/index.js

@@ -56,6 +56,9 @@ const rule$2 = {
                             type: 'string',
                         },
                     },
+                    requireExplicitEffectDeps: {
+                        type: 'boolean',
+                    }
                 },
             },
         ],
@@ -71,10 +74,12 @@ const rule$2 = {
         const experimental_autoDependenciesHooks = rawOptions && Array.isArray(rawOptions.experimental_autoDependenciesHooks)
             ? rawOptions.experimental_autoDependenciesHooks
             : [];
+        const requireExplicitEffectDeps = rawOptions && rawOptions.requireExplicitEffectDeps || false;
         const options = {
             additionalHooks,
             experimental_autoDependenciesHooks,
             enableDangerousAutofixThisMayCauseInfiniteLoops,
+            requireExplicitEffectDeps,
         };
         function reportProblem(problem) {
             if (enableDangerousAutofixThisMayCauseInfiniteLoops) {
@@ -934,6 +939,13 @@ const rule$2 = {
                 });
                 return;
             }
+            if (!maybeNode && isEffect && options.requireExplicitEffectDeps) {
+                reportProblem({
+                    node: reactiveHook,
+                    message: `React Hook ${reactiveHookName} always requires dependencies. ` +
+                        `Please add a dependency array or an explicit \`undefined\``
+                });
+            }
             const isAutoDepsHook = options.experimental_autoDependenciesHooks.includes(reactiveHookName);
             if ((!declaredDependenciesNode ||
                 (isAutoDepsHook &&

compiled/facebook-www/REVISION

@@ -1 +1 @@
-bfaeb4a46175fa0f4edf2eba58349d5029e5e86e
+99efc627a5a8cb56f50cfffee544c86c49572b6f

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-bfaeb4a46175fa0f4edf2eba58349d5029e5e86e
+99efc627a5a8cb56f50cfffee544c86c49572b6f

compiled/facebook-www/React-dev.classic.js

@@ -1537,7 +1537,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";
+    exports.version = "19.2.0-www-classic-99efc627-20250523";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1537,7 +1537,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-modern-bfaeb4a4-20250522";
+    exports.version = "19.2.0-www-modern-99efc627-20250523";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";
+exports.version = "19.2.0-www-classic-99efc627-20250523";

compiled/facebook-www/React-prod.modern.js

@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-bfaeb4a4-20250522";
+exports.version = "19.2.0-www-modern-99efc627-20250523";

compiled/facebook-www/React-profiling.classic.js

@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";
+exports.version = "19.2.0-www-classic-99efc627-20250523";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-bfaeb4a4-20250522";
+exports.version = "19.2.0-www-modern-99efc627-20250523";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -19080,10 +19080,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.2.0-www-classic-bfaeb4a4-20250522",
+        version: "19.2.0-www-classic-99efc627-20250523",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.2.0-www-classic-bfaeb4a4-20250522"
+        reconcilerVersion: "19.2.0-www-classic-99efc627-20250523"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19117,7 +19117,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";
+    exports.version = "19.2.0-www-classic-99efc627-20250523";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&