Skip to content

Commit

Permalink
Add support for setNativeProps to Fabric (#25737)
Browse files Browse the repository at this point in the history
Add support for `setNativeProps` in Fabric to make migration to the new
architecture easier. The React Native part of this has already landed in
the core and iOS in
facebook/react-native@1d3fa40.

It is still recommended to move away from `setNativeProps` because the
API will not work with future features.

DiffTrain build for [b14d7fa](b14d7fa)
[View git log for this commit](https://github.com/facebook/react/commits/b14d7fa4b88dad5f0017d084e462952c700aa2ad)
  • Loading branch information
sammy-SC committed Dec 9, 2022
1 parent ba16451 commit a434b3e
Show file tree
Hide file tree
Showing 35 changed files with 56 additions and 57 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1c7055ddbbdae81224f998e42832d882fde06686
b14d7fa4b88dad5f0017d084e462952c700aa2ad
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1c7055ddbbdae81224f998e42832d882fde06686
b14d7fa4b88dad5f0017d084e462952c700aa2ad
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-classic-b14d7fa4b-20221209";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-modern-b14d7fa4b-20221209";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-1c7055ddb-20221208";
exports.version = "18.3.0-www-classic-b14d7fa4b-20221209";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-1c7055ddb-20221208";
exports.version = "18.3.0-www-modern-b14d7fa4b-20221209";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-1c7055ddb-20221208";
exports.version = "18.3.0-www-classic-b14d7fa4b-20221209";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-1c7055ddb-20221208";
exports.version = "18.3.0-www-modern-b14d7fa4b-20221209";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-classic-b14d7fa4b-20221209";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-modern-b14d7fa4b-20221209";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -9782,7 +9782,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-1c7055ddb-20221208",
version: "18.3.0-www-classic-b14d7fa4b-20221209",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1336 = {
Expand Down Expand Up @@ -9813,7 +9813,7 @@ var internals$jscomp$inline_1336 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1337 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9449,7 +9449,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-1c7055ddb-20221208",
version: "18.3.0-www-modern-b14d7fa4b-20221209",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1327 = {
Expand Down Expand Up @@ -9480,7 +9480,7 @@ var internals$jscomp$inline_1327 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1328 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -42530,7 +42530,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-classic-b14d7fa4b-20221209";

function createPortal(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -42254,7 +42254,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-modern-b14d7fa4b-20221209";

function createPortal(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15537,7 +15537,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1773 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-1c7055ddb-20221208",
version: "18.3.0-www-classic-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2154 = {
Expand Down Expand Up @@ -15567,7 +15567,7 @@ var internals$jscomp$inline_2154 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2155 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15809,4 +15809,4 @@ exports.unstable_renderSubtreeIntoContainer = function(
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15098,7 +15098,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1741 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-1c7055ddb-20221208",
version: "18.3.0-www-modern-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2129 = {
Expand Down Expand Up @@ -15129,7 +15129,7 @@ var internals$jscomp$inline_2129 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2130 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15317,4 +15317,4 @@ exports.unstable_flushControlled = function(fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16308,7 +16308,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1847 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-1c7055ddb-20221208",
version: "18.3.0-www-classic-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
(function(internals) {
Expand Down Expand Up @@ -16352,7 +16352,7 @@ var devToolsConfig$jscomp$inline_1847 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -16581,7 +16581,7 @@ exports.unstable_renderSubtreeIntoContainer = function(
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15859,7 +15859,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1815 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-1c7055ddb-20221208",
version: "18.3.0-www-modern-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
(function(internals) {
Expand Down Expand Up @@ -15904,7 +15904,7 @@ var devToolsConfig$jscomp$inline_1815 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function(children, container) {
Expand Down Expand Up @@ -16079,7 +16079,7 @@ exports.unstable_flushControlled = function(fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMForked-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -42530,7 +42530,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-classic-b14d7fa4b-20221209";

function createPortal(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMForked-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -42254,7 +42254,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-modern-b14d7fa4b-20221209";

function createPortal(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMForked-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15537,7 +15537,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1773 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-1c7055ddb-20221208",
version: "18.3.0-www-classic-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2154 = {
Expand Down Expand Up @@ -15567,7 +15567,7 @@ var internals$jscomp$inline_2154 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2155 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15809,4 +15809,4 @@ exports.unstable_renderSubtreeIntoContainer = function(
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMForked-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15098,7 +15098,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1741 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-1c7055ddb-20221208",
version: "18.3.0-www-modern-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2129 = {
Expand Down Expand Up @@ -15129,7 +15129,7 @@ var internals$jscomp$inline_2129 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2130 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15317,4 +15317,4 @@ exports.unstable_flushControlled = function(fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMForked-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16308,7 +16308,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1847 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-1c7055ddb-20221208",
version: "18.3.0-www-classic-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
(function(internals) {
Expand Down Expand Up @@ -16352,7 +16352,7 @@ var devToolsConfig$jscomp$inline_1847 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -16581,7 +16581,7 @@ exports.unstable_renderSubtreeIntoContainer = function(
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMForked-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15859,7 +15859,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1815 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-1c7055ddb-20221208",
version: "18.3.0-www-modern-b14d7fa4b-20221209",
rendererPackageName: "react-dom"
};
(function(internals) {
Expand Down Expand Up @@ -15904,7 +15904,7 @@ var devToolsConfig$jscomp$inline_1815 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-1c7055ddb-20221208"
reconcilerVersion: "18.3.0-next-b14d7fa4b-20221209"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function(children, container) {
Expand Down Expand Up @@ -16079,7 +16079,7 @@ exports.unstable_flushControlled = function(fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-1c7055ddb-20221208";
exports.version = "18.3.0-next-b14d7fa4b-20221209";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if (__DEV__) {

var React = require("react");

var ReactVersion = "18.3.0-www-classic-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-classic-b14d7fa4b-20221209";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if (__DEV__) {

var React = require("react");

var ReactVersion = "18.3.0-www-modern-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-modern-b14d7fa4b-20221209";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -3632,4 +3632,4 @@ exports.renderToString = function(children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-1c7055ddb-20221208";
exports.version = "18.3.0-www-classic-b14d7fa4b-20221209";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -3545,4 +3545,4 @@ exports.renderToString = function(children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-1c7055ddb-20221208";
exports.version = "18.3.0-www-modern-b14d7fa4b-20221209";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -38807,7 +38807,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-classic-b14d7fa4b-20221209";

function createPortal(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -38369,7 +38369,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-1c7055ddb-20221208";
var ReactVersion = "18.3.0-www-modern-b14d7fa4b-20221209";

function createPortal(
children,
Expand Down
Loading

0 comments on commit a434b3e

Please sign in to comment.