Recover from SSR error in Flight fixture

facebook · Feb 18, 2024 · 86e2f11 · 86e2f11
1 parent c1fd2a9
commit 86e2f11
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/fixtures/flight/server/global.js b/fixtures/flight/server/global.js
@@ -174,8 +174,18 @@ app.all('/', async function (req, res, next) {
       const {pipe} = renderToPipeableStream(React.createElement(Root), {
         bootstrapScripts: mainJSChunks,
         formState: formState,
+        onShellReady() {
+          pipe(res);
+        },
+        onShellError(error) {
+          const {pipe: pipeError} = renderToPipeableStream(
+            React.createElement('html', null, React.createElement('body')), {
+              bootstrapScripts: mainJSChunks,
+            }
+          );
+          pipeError(res);
+        }
       });
-      pipe(res);
     } catch (e) {
       console.error(`Failed to SSR: ${e.stack}`);
       res.statusCode = 500;

diff --git a/fixtures/flight/server/region.js b/fixtures/flight/server/region.js
@@ -104,7 +104,6 @@ app.get('/', async function (req, res) {
 
 app.post('/', bodyParser.text(), async function (req, res) {
   const {
-    renderToPipeableStream,
     decodeReply,
     decodeReplyFromBusboy,
     decodeAction,