Skip to content

Commit

Permalink
Remove invokeGuardedCallback and replay trick (#28515)
Browse files Browse the repository at this point in the history
We broke the ability to "break on uncaught exceptions" by adding a
try/catch higher up in the scheduling. We're giving up on fixing that so
we can remove the replay trick inside an event handler.

The issue with that approach is that we end up double logging a lot of
errors in DEV since they get reported to the page.

It's also a lot of complexity around this feature.

DiffTrain build for commit 89021fb.
  • Loading branch information
sebmarkbage committed Mar 12, 2024
1 parent 004bb7f commit 81f40d0
Show file tree
Hide file tree
Showing 13 changed files with 20,566 additions and 21,870 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if (__DEV__) {
}
var dynamicFlags = require("ReactNativeInternalFeatureFlags");

var ReactVersion = "18.3.0-canary-9c48fb25e-20240311";
var ReactVersion = "18.3.0-canary-89021fb4e-20240311";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -628,4 +628,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-9c48fb25e-20240311";
exports.version = "18.3.0-canary-89021fb4e-20240311";
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-9c48fb25e-20240311";
exports.version = "18.3.0-canary-89021fb4e-20240311";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9c48fb25ecc467b37abb3e145c6e25e311dcdde5
89021fb4ec9aa82194b0788566e736a4cedfc0e4
Loading

0 comments on commit 81f40d0

Please sign in to comment.