Skip to content

Commit 3f719c7

Browse files
hoxyqhoxyq
committed
Fix/add missing else branch for renders with no props change (#34837)
Stacked on #34822. Fixes a bug introduced in #34370. Just copying the lower else branch to the `properties.length` else branch at the top. DiffTrain build for [47905a7](47905a7)
1 parent 990171b commit 3f719c7

24 files changed

+259
-179
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.3.0-native-fb-93d4458f-20251013
1+
19.3.0-native-fb-47905a79-20251013

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<fbee8b10d30fac1207aa8c8cc0039314>>
10+
* @generated SignedSource<<61c9693ac4f29a611595d1415b8da7d6>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.3.0-native-fb-93d4458f-20251013";
407+
exports.version = "19.3.0-native-fb-47905a79-20251013";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e00ca1b235145266fa0df0e704eb4668>>
10+
* @generated SignedSource<<0ae5bcff137305a28d2eb0a9eab423e4>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.3.0-native-fb-93d4458f-20251013";
206+
exports.version = "19.3.0-native-fb-47905a79-20251013";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e00ca1b235145266fa0df0e704eb4668>>
10+
* @generated SignedSource<<0ae5bcff137305a28d2eb0a9eab423e4>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.3.0-native-fb-93d4458f-20251013";
206+
exports.version = "19.3.0-native-fb-47905a79-20251013";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 49 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<db8fb3e7e239fd868c6114cc5122d8ca>>
10+
* @generated SignedSource<<8dd85c56d7a134dc499f122e75dbc22d>>
1111
*/
1212

1313
/*
@@ -4311,33 +4311,53 @@ __DEV__ &&
43114311
child,
43124312
0
43134313
)),
4314-
1 < child.length &&
4315-
(props &&
4316-
!alreadyWarnedForDeepEquality &&
4317-
0 === (alternate.lanes & committedLanes) &&
4318-
100 < fiber.actualDuration
4319-
? ((alreadyWarnedForDeepEquality = !0),
4320-
(child[0] = reusableDeeplyEqualPropsEntry),
4321-
(reusableComponentDevToolDetails.color = "warning"),
4322-
(reusableComponentDevToolDetails.tooltipText =
4323-
DEEP_EQUALITY_WARNING))
4324-
: ((reusableComponentDevToolDetails.color = wasHydrated),
4325-
(reusableComponentDevToolDetails.tooltipText = name)),
4326-
(reusableComponentDevToolDetails.properties = child),
4327-
(reusableComponentOptions.start = startTime),
4328-
(reusableComponentOptions.end = endTime),
4329-
null != selfTime
4330-
? selfTime.run(
4331-
performance.measure.bind(
4332-
performance,
4314+
1 < child.length
4315+
? (props &&
4316+
!alreadyWarnedForDeepEquality &&
4317+
0 === (alternate.lanes & committedLanes) &&
4318+
100 < fiber.actualDuration
4319+
? ((alreadyWarnedForDeepEquality = !0),
4320+
(child[0] = reusableDeeplyEqualPropsEntry),
4321+
(reusableComponentDevToolDetails.color = "warning"),
4322+
(reusableComponentDevToolDetails.tooltipText =
4323+
DEEP_EQUALITY_WARNING))
4324+
: ((reusableComponentDevToolDetails.color = wasHydrated),
4325+
(reusableComponentDevToolDetails.tooltipText = name)),
4326+
(reusableComponentDevToolDetails.properties = child),
4327+
(reusableComponentOptions.start = startTime),
4328+
(reusableComponentOptions.end = endTime),
4329+
null != selfTime
4330+
? selfTime.run(
4331+
performance.measure.bind(
4332+
performance,
4333+
"\u200b" + name,
4334+
reusableComponentOptions
4335+
)
4336+
)
4337+
: performance.measure(
43334338
"\u200b" + name,
43344339
reusableComponentOptions
4340+
))
4341+
: null != selfTime
4342+
? selfTime.run(
4343+
console.timeStamp.bind(
4344+
console,
4345+
name,
4346+
startTime,
4347+
endTime,
4348+
COMPONENTS_TRACK,
4349+
void 0,
4350+
wasHydrated
43354351
)
43364352
)
4337-
: performance.measure(
4338-
"\u200b" + name,
4339-
reusableComponentOptions
4340-
)))
4353+
: console.timeStamp(
4354+
name,
4355+
startTime,
4356+
endTime,
4357+
COMPONENTS_TRACK,
4358+
void 0,
4359+
wasHydrated
4360+
))
43414361
: null != selfTime
43424362
? selfTime.run(
43434363
console.timeStamp.bind(
@@ -30097,11 +30117,11 @@ __DEV__ &&
3009730117
};
3009830118
(function () {
3009930119
var isomorphicReactPackageVersion = React.version;
30100-
if ("19.3.0-native-fb-93d4458f-20251013" !== isomorphicReactPackageVersion)
30120+
if ("19.3.0-native-fb-47905a79-20251013" !== isomorphicReactPackageVersion)
3010130121
throw Error(
3010230122
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
3010330123
(isomorphicReactPackageVersion +
30104-
"\n - react-dom: 19.3.0-native-fb-93d4458f-20251013\nLearn more: https://react.dev/warnings/version-mismatch")
30124+
"\n - react-dom: 19.3.0-native-fb-47905a79-20251013\nLearn more: https://react.dev/warnings/version-mismatch")
3010530125
);
3010630126
})();
3010730127
("function" === typeof Map &&
@@ -30138,10 +30158,10 @@ __DEV__ &&
3013830158
!(function () {
3013930159
var internals = {
3014030160
bundleType: 1,
30141-
version: "19.3.0-native-fb-93d4458f-20251013",
30161+
version: "19.3.0-native-fb-47905a79-20251013",
3014230162
rendererPackageName: "react-dom",
3014330163
currentDispatcherRef: ReactSharedInternals,
30144-
reconcilerVersion: "19.3.0-native-fb-93d4458f-20251013"
30164+
reconcilerVersion: "19.3.0-native-fb-47905a79-20251013"
3014530165
};
3014630166
internals.overrideHookState = overrideHookState;
3014730167
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30291,5 +30311,5 @@ __DEV__ &&
3029130311
listenToAllSupportedEvents(container);
3029230312
return new ReactDOMHydrationRoot(initialChildren);
3029330313
};
30294-
exports.version = "19.3.0-native-fb-93d4458f-20251013";
30314+
exports.version = "19.3.0-native-fb-47905a79-20251013";
3029530315
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e46a0744f709d3b3d91aab5184a49323>>
10+
* @generated SignedSource<<651b81127c4c7e5be73e2be0215d4616>>
1111
*/
1212

1313
/*
@@ -17581,14 +17581,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1758117581
};
1758217582
var isomorphicReactPackageVersion$jscomp$inline_2060 = React.version;
1758317583
if (
17584-
"19.3.0-native-fb-93d4458f-20251013" !==
17584+
"19.3.0-native-fb-47905a79-20251013" !==
1758517585
isomorphicReactPackageVersion$jscomp$inline_2060
1758617586
)
1758717587
throw Error(
1758817588
formatProdErrorMessage(
1758917589
527,
1759017590
isomorphicReactPackageVersion$jscomp$inline_2060,
17591-
"19.3.0-native-fb-93d4458f-20251013"
17591+
"19.3.0-native-fb-47905a79-20251013"
1759217592
)
1759317593
);
1759417594
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17610,10 +17610,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1761017610
};
1761117611
var internals$jscomp$inline_2637 = {
1761217612
bundleType: 0,
17613-
version: "19.3.0-native-fb-93d4458f-20251013",
17613+
version: "19.3.0-native-fb-47905a79-20251013",
1761417614
rendererPackageName: "react-dom",
1761517615
currentDispatcherRef: ReactSharedInternals,
17616-
reconcilerVersion: "19.3.0-native-fb-93d4458f-20251013"
17616+
reconcilerVersion: "19.3.0-native-fb-47905a79-20251013"
1761717617
};
1761817618
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1761917619
var hook$jscomp$inline_2638 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17720,4 +17720,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1772017720
listenToAllSupportedEvents(container);
1772117721
return new ReactDOMHydrationRoot(initialChildren);
1772217722
};
17723-
exports.version = "19.3.0-native-fb-93d4458f-20251013";
17723+
exports.version = "19.3.0-native-fb-47905a79-20251013";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<24b7476e748c74de04443547459f43c8>>
10+
* @generated SignedSource<<bf6542e708d19ec3f2e687bdf95a8bfc>>
1111
*/
1212

1313
/*
@@ -19702,14 +19702,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1970219702
};
1970319703
var isomorphicReactPackageVersion$jscomp$inline_2375 = React.version;
1970419704
if (
19705-
"19.3.0-native-fb-93d4458f-20251013" !==
19705+
"19.3.0-native-fb-47905a79-20251013" !==
1970619706
isomorphicReactPackageVersion$jscomp$inline_2375
1970719707
)
1970819708
throw Error(
1970919709
formatProdErrorMessage(
1971019710
527,
1971119711
isomorphicReactPackageVersion$jscomp$inline_2375,
19712-
"19.3.0-native-fb-93d4458f-20251013"
19712+
"19.3.0-native-fb-47905a79-20251013"
1971319713
)
1971419714
);
1971519715
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19731,10 +19731,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1973119731
};
1973219732
var internals$jscomp$inline_2382 = {
1973319733
bundleType: 0,
19734-
version: "19.3.0-native-fb-93d4458f-20251013",
19734+
version: "19.3.0-native-fb-47905a79-20251013",
1973519735
rendererPackageName: "react-dom",
1973619736
currentDispatcherRef: ReactSharedInternals,
19737-
reconcilerVersion: "19.3.0-native-fb-93d4458f-20251013",
19737+
reconcilerVersion: "19.3.0-native-fb-47905a79-20251013",
1973819738
getLaneLabelMap: function () {
1973919739
for (
1974019740
var map = new Map(), lane = 1, index$332 = 0;
@@ -19857,4 +19857,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1985719857
listenToAllSupportedEvents(container);
1985819858
return new ReactDOMHydrationRoot(initialChildren);
1985919859
};
19860-
exports.version = "19.3.0-native-fb-93d4458f-20251013";
19860+
exports.version = "19.3.0-native-fb-47905a79-20251013";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 49 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ed1546669c589e11f0a25c4cfe23412f>>
10+
* @generated SignedSource<<a4f4f172c7e0cce1b586add2b7ba3072>>
1111
*/
1212

1313
/*
@@ -4319,33 +4319,53 @@ __DEV__ &&
43194319
child,
43204320
0
43214321
)),
4322-
1 < child.length &&
4323-
(props &&
4324-
!alreadyWarnedForDeepEquality &&
4325-
0 === (alternate.lanes & committedLanes) &&
4326-
100 < fiber.actualDuration
4327-
? ((alreadyWarnedForDeepEquality = !0),
4328-
(child[0] = reusableDeeplyEqualPropsEntry),
4329-
(reusableComponentDevToolDetails.color = "warning"),
4330-
(reusableComponentDevToolDetails.tooltipText =
4331-
DEEP_EQUALITY_WARNING))
4332-
: ((reusableComponentDevToolDetails.color = wasHydrated),
4333-
(reusableComponentDevToolDetails.tooltipText = name)),
4334-
(reusableComponentDevToolDetails.properties = child),
4335-
(reusableComponentOptions.start = startTime),
4336-
(reusableComponentOptions.end = endTime),
4337-
null != selfTime
4338-
? selfTime.run(
4339-
performance.measure.bind(
4340-
performance,
4322+
1 < child.length
4323+
? (props &&
4324+
!alreadyWarnedForDeepEquality &&
4325+
0 === (alternate.lanes & committedLanes) &&
4326+
100 < fiber.actualDuration
4327+
? ((alreadyWarnedForDeepEquality = !0),
4328+
(child[0] = reusableDeeplyEqualPropsEntry),
4329+
(reusableComponentDevToolDetails.color = "warning"),
4330+
(reusableComponentDevToolDetails.tooltipText =
4331+
DEEP_EQUALITY_WARNING))
4332+
: ((reusableComponentDevToolDetails.color = wasHydrated),
4333+
(reusableComponentDevToolDetails.tooltipText = name)),
4334+
(reusableComponentDevToolDetails.properties = child),
4335+
(reusableComponentOptions.start = startTime),
4336+
(reusableComponentOptions.end = endTime),
4337+
null != selfTime
4338+
? selfTime.run(
4339+
performance.measure.bind(
4340+
performance,
4341+
"\u200b" + name,
4342+
reusableComponentOptions
4343+
)
4344+
)
4345+
: performance.measure(
43414346
"\u200b" + name,
43424347
reusableComponentOptions
4348+
))
4349+
: null != selfTime
4350+
? selfTime.run(
4351+
console.timeStamp.bind(
4352+
console,
4353+
name,
4354+
startTime,
4355+
endTime,
4356+
COMPONENTS_TRACK,
4357+
void 0,
4358+
wasHydrated
43434359
)
43444360
)
4345-
: performance.measure(
4346-
"\u200b" + name,
4347-
reusableComponentOptions
4348-
)))
4361+
: console.timeStamp(
4362+
name,
4363+
startTime,
4364+
endTime,
4365+
COMPONENTS_TRACK,
4366+
void 0,
4367+
wasHydrated
4368+
))
43494369
: null != selfTime
43504370
? selfTime.run(
43514371
console.timeStamp.bind(
@@ -30153,11 +30173,11 @@ __DEV__ &&
3015330173
};
3015430174
(function () {
3015530175
var isomorphicReactPackageVersion = React.version;
30156-
if ("19.3.0-native-fb-93d4458f-20251013" !== isomorphicReactPackageVersion)
30176+
if ("19.3.0-native-fb-47905a79-20251013" !== isomorphicReactPackageVersion)
3015730177
throw Error(
3015830178
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
3015930179
(isomorphicReactPackageVersion +
30160-
"\n - react-dom: 19.3.0-native-fb-93d4458f-20251013\nLearn more: https://react.dev/warnings/version-mismatch")
30180+
"\n - react-dom: 19.3.0-native-fb-47905a79-20251013\nLearn more: https://react.dev/warnings/version-mismatch")
3016130181
);
3016230182
})();
3016330183
("function" === typeof Map &&
@@ -30194,10 +30214,10 @@ __DEV__ &&
3019430214
!(function () {
3019530215
var internals = {
3019630216
bundleType: 1,
30197-
version: "19.3.0-native-fb-93d4458f-20251013",
30217+
version: "19.3.0-native-fb-47905a79-20251013",
3019830218
rendererPackageName: "react-dom",
3019930219
currentDispatcherRef: ReactSharedInternals,
30200-
reconcilerVersion: "19.3.0-native-fb-93d4458f-20251013"
30220+
reconcilerVersion: "19.3.0-native-fb-47905a79-20251013"
3020130221
};
3020230222
internals.overrideHookState = overrideHookState;
3020330223
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30663,7 +30683,7 @@ __DEV__ &&
3066330683
exports.useFormStatus = function () {
3066430684
return resolveDispatcher().useHostTransitionStatus();
3066530685
};
30666-
exports.version = "19.3.0-native-fb-93d4458f-20251013";
30686+
exports.version = "19.3.0-native-fb-47905a79-20251013";
3066730687
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
3066830688
"function" ===
3066930689
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)