-
Notifications
You must be signed in to change notification settings - Fork 49.8k
Performance Tracks: log properties diff for renders in DEV if no console task available #34370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hoxyq
merged 1 commit into
facebook:main
from
hoxyq:log-properties-for-renders-even-if-no-console-task
Sep 3, 2025
Merged
Performance Tracks: log properties diff for renders in DEV if no console task available #34370
hoxyq
merged 1 commit into
facebook:main
from
hoxyq:log-properties-for-renders-even-if-no-console-task
Sep 3, 2025
+46
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ole task available
|
Comparing: ac3e705...d7573cd Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
Sep 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ole task available (#34370) React Native doesn't support `console.createTask` yet, but it does support `performance.measure` and extensibility APIs for Performance panel, including `detail.devtools` field. Previously, this logic was gated with `if (__DEV__ && debugTask)`, now `debugTask` is no longer required to log render. If there is no console task, we will just call `performance.measure(...)`. The same pattern is used in other reporters. DiffTrain build for [2805f0e](2805f0e)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ole task available (#34370) React Native doesn't support `console.createTask` yet, but it does support `performance.measure` and extensibility APIs for Performance panel, including `detail.devtools` field. Previously, this logic was gated with `if (__DEV__ && debugTask)`, now `debugTask` is no longer required to log render. If there is no console task, we will just call `performance.measure(...)`. The same pattern is used in other reporters. DiffTrain build for [2805f0e](2805f0e)
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 4, 2025
…ole task available (facebook#34370) React Native doesn't support `console.createTask` yet, but it does support `performance.measure` and extensibility APIs for Performance panel, including `detail.devtools` field. Previously, this logic was gated with `if (__DEV__ && debugTask)`, now `debugTask` is no longer required to log render. If there is no console task, we will just call `performance.measure(...)`. The same pattern is used in other reporters.
hoxyq
added a commit
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native doesn't support
console.createTaskyet, but it does supportperformance.measureand extensibility APIs for Performance panel, includingdetail.devtoolsfield.Previously, this logic was gated with
if (__DEV__ && debugTask), nowdebugTaskis no longer required to log render. If there is no console task, we will just callperformance.measure(...). The same pattern is used in other reporters.