Skip to content

Conversation

@hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Sep 3, 2025

React Native doesn't support console.createTask yet, but it does support performance.measure and extensibility APIs for Performance panel, including detail.devtools field.

Previously, this logic was gated with if (__DEV__ && debugTask), now debugTask is no longer required to log render. If there is no console task, we will just call performance.measure(...). The same pattern is used in other reporters.

@hoxyq hoxyq requested review from eps1lon and sebmarkbage September 3, 2025 14:12
@meta-cla meta-cla bot added the CLA Signed label Sep 3, 2025
@react-sizebot
Copy link

Comparing: ac3e705...d7573cd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.31 kB 530.31 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 657.78 kB 657.78 kB = 115.66 kB 115.66 kB
facebook-www/ReactDOM-prod.classic.js = 677.76 kB 677.76 kB = 118.94 kB 118.94 kB
facebook-www/ReactDOM-prod.modern.js = 668.19 kB 668.19 kB = 117.26 kB 117.26 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d7573cd

@hoxyq hoxyq merged commit 2805f0e into facebook:main Sep 3, 2025
247 checks passed
@hoxyq hoxyq deleted the log-properties-for-renders-even-if-no-console-task branch September 3, 2025 16:08
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
…ole task available (#34370)

React Native doesn't support `console.createTask` yet, but it does
support `performance.measure` and extensibility APIs for Performance
panel, including `detail.devtools` field.

Previously, this logic was gated with `if (__DEV__ && debugTask)`, now
`debugTask` is no longer required to log render. If there is no console
task, we will just call `performance.measure(...)`. The same pattern is
used in other reporters.

DiffTrain build for [2805f0e](2805f0e)
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
…ole task available (#34370)

React Native doesn't support `console.createTask` yet, but it does
support `performance.measure` and extensibility APIs for Performance
panel, including `detail.devtools` field.

Previously, this logic was gated with `if (__DEV__ && debugTask)`, now
`debugTask` is no longer required to log render. If there is no console
task, we will just call `performance.measure(...)`. The same pattern is
used in other reporters.

DiffTrain build for [2805f0e](2805f0e)
EugeneChoi4 pushed a commit to EugeneChoi4/react that referenced this pull request Sep 4, 2025
…ole task available (facebook#34370)

React Native doesn't support `console.createTask` yet, but it does
support `performance.measure` and extensibility APIs for Performance
panel, including `detail.devtools` field.

Previously, this logic was gated with `if (__DEV__ && debugTask)`, now
`debugTask` is no longer required to log render. If there is no console
task, we will just call `performance.measure(...)`. The same pattern is
used in other reporters.
hoxyq added a commit that referenced this pull request Oct 13, 2025
Stacked on #34822.
Fixes a bug introduced in #34370.

Just copying the lower else branch to the `properties.length` else
branch at the top.
github-actions bot pushed a commit that referenced this pull request Oct 13, 2025
Stacked on #34822.
Fixes a bug introduced in #34370.

Just copying the lower else branch to the `properties.length` else
branch at the top.

DiffTrain build for [47905a7](47905a7)
github-actions bot pushed a commit that referenced this pull request Oct 13, 2025
Stacked on #34822.
Fixes a bug introduced in #34370.

Just copying the lower else branch to the `properties.length` else
branch at the top.

DiffTrain build for [47905a7](47905a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants