Remove IE8 event.target polyfill via srcElement

facebook · Nov 10, 2017 · 38dfbe3 · 38dfbe3
1 parent 54051f9
commit 38dfbe3
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 35 deletions.
diff --git a/packages/react-dom/src/events/__tests__/SyntheticClipboardEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticClipboardEvent-test.js
@@ -44,14 +44,6 @@ describe('SyntheticClipboardEvent', () => {
   });
 
   describe('EventInterface', () => {
-    it('normalizes properties from the Event interface', () => {
-      var target = document.createElement('div');
-      var syntheticEvent = createEvent({srcElement: target});
-
-      expect(syntheticEvent.target).toBe(target);
-      expect(syntheticEvent.type).toBe(undefined);
-    });
-
     it('is able to `preventDefault` and `stopPropagation`', () => {
       var nativeEvent = {};
       var syntheticEvent = createEvent(nativeEvent);

diff --git a/packages/react-dom/src/events/__tests__/SyntheticEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticEvent-test.js
@@ -30,14 +30,6 @@ describe('SyntheticEvent', () => {
     };
   });
 
-  it('should normalize `target` from the nativeEvent', () => {
-    var target = document.createElement('div');
-    var syntheticEvent = createEvent({srcElement: target});
-
-    expect(syntheticEvent.target).toBe(target);
-    expect(syntheticEvent.type).toBe(undefined);
-  });
-
   it('should be able to `preventDefault`', () => {
     var nativeEvent = {};
     var syntheticEvent = createEvent(nativeEvent);
@@ -80,7 +72,7 @@ describe('SyntheticEvent', () => {
   it('should be nullified if the synthetic event has called destructor and log warnings', () => {
     spyOn(console, 'error');
     var target = document.createElement('div');
-    var syntheticEvent = createEvent({srcElement: target});
+    var syntheticEvent = createEvent({target});
     syntheticEvent.destructor();
     expect(syntheticEvent.type).toBe(null);
     expect(syntheticEvent.nativeEvent).toBe(null);
@@ -100,7 +92,7 @@ describe('SyntheticEvent', () => {
   it('should warn when setting properties of a destructored synthetic event', () => {
     spyOn(console, 'error');
     var target = document.createElement('div');
-    var syntheticEvent = createEvent({srcElement: target});
+    var syntheticEvent = createEvent({target});
     syntheticEvent.destructor();
     expect((syntheticEvent.type = 'MouseEvent')).toBe('MouseEvent');
     expectDev(console.error.calls.count()).toBe(1);

diff --git a/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js
@@ -90,14 +90,6 @@ describe('SyntheticKeyboardEvent', () => {
   });
 
   describe('EventInterface', () => {
-    it('normalizes properties from the Event interface', () => {
-      var target = document.createElement('div');
-      var syntheticEvent = createEvent({srcElement: target});
-
-      expect(syntheticEvent.target).toBe(target);
-      expect(syntheticEvent.type).toBe(undefined);
-    });
-
     it('is able to `preventDefault` and `stopPropagation`', () => {
       var nativeEvent = {};
       var syntheticEvent = createEvent(nativeEvent);

diff --git a/packages/react-dom/src/events/__tests__/SyntheticWheelEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticWheelEvent-test.js
@@ -24,14 +24,6 @@ describe('SyntheticWheelEvent', () => {
     };
   });
 
-  it('should normalize properties from the Event interface', () => {
-    var target = document.createElement('div');
-    var syntheticEvent = createEvent({srcElement: target});
-
-    expect(syntheticEvent.target).toBe(target);
-    expect(syntheticEvent.type).toBe(undefined);
-  });
-
   it('should normalize properties from the MouseEvent interface', () => {
     expect(createEvent({which: 2, button: 1}).button).toBe(1);
   });

diff --git a/packages/react-dom/src/events/getEventTarget.js b/packages/react-dom/src/events/getEventTarget.js
@@ -15,7 +15,7 @@ import {TEXT_NODE} from '../shared/HTMLNodeType';
  * @return {DOMEventTarget} Target node.
  */
 function getEventTarget(nativeEvent) {
-  var target = nativeEvent.target || nativeEvent.srcElement || window;
+  var target = nativeEvent.target || window;
 
   // Normalize SVG <use> element events #4963
   if (target.correspondingUseElement) {