f

facebook · Sep 3, 2024 · 24c51eb · 24c51eb
1 parent 87482f0
commit 24c51eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts b/compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts
@@ -235,7 +235,7 @@ const EnvironmentConfigSchema = z.object({
   /**
    * Enables inlining ReactElement object literals in place of JSX
    * An alternative to the standard JSX transform which replaces JSX with React's jsxProd() runtime
-   * Currently a prod-only optimizaiton, requiring Fast JSX features from React 19
+   * Currently a prod-only optimization, requiring Fast JSX dependencies
    */
   enableInlineJsxTransform: z.boolean().default(false),
 

diff --git a/compiler/packages/babel-plugin-react-compiler/src/Optimization/InlineJsxTransform.ts b/compiler/packages/babel-plugin-react-compiler/src/Optimization/InlineJsxTransform.ts
@@ -273,6 +273,7 @@ function createPropsProperties(
   return {refProperty, keyProperty, propsProperty};
 }
 
+// TODO: Make PROD only with conditional statements
 export function inlineJsxTransform(fn: HIRFunction): void {
   for (const [, block] of fn.body.blocks) {
     let nextInstructions: Array<Instruction> | null = null;
@@ -301,6 +302,8 @@ export function inlineJsxTransform(fn: HIRFunction): void {
                   instr,
                   nextInstructions,
                   '$$typeof',
+                  // TODO: Add this to config so we can switch between
+                  // react.element / react.transitional.element
                   'react.transitional.element',
                 ),
                 createTagProperty(fn, instr, nextInstructions, instr.value.tag),
@@ -337,6 +340,8 @@ export function inlineJsxTransform(fn: HIRFunction): void {
                   instr,
                   nextInstructions,
                   '$$typeof',
+                  // TODO: Add this to config so we can switch between
+                  // react.element / react.transitional.element
                   'react.transitional.element',
                 ),
                 createSymbolProperty(