dedupe warning

facebook · Mar 5, 2020 · 2176e6d · 2176e6d
1 parent ffabb83
commit 2176e6d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/packages/react/src/ReactContext.js b/packages/react/src/ReactContext.js
@@ -57,6 +57,7 @@ export function createContext<T>(
 
   let hasWarnedAboutUsingNestedContextConsumers = false;
   let hasWarnedAboutUsingConsumerProvider = false;
+  let hasWarnedAboutDisplayNameOnConsumer = false;
 
   if (__DEV__) {
     // A separate object, but proxies back to the original context object for
@@ -125,10 +126,13 @@ export function createContext<T>(
           return context.displayName;
         },
         set() {
-          console.warn(
-            'Setting `displayName` on Context.Consumer has no effect. ' +
-              "You should set it directly on the context with Context.displayName = 'NamedContext'.",
-          );
+          if (!hasWarnedAboutDisplayNameOnConsumer) {
+            console.warn(
+              'Setting `displayName` on Context.Consumer has no effect. ' +
+                "You should set it directly on the context with Context.displayName = 'NamedContext'.",
+            );
+            hasWarnedAboutDisplayNameOnConsumer = true;
+          }
         },
       },
     });

diff --git a/packages/react/src/__tests__/ReactContextValidator-test.js b/packages/react/src/__tests__/ReactContextValidator-test.js
@@ -706,5 +706,8 @@ describe('ReactContextValidator', () => {
         "You should set it directly on the context with Context.displayName = 'NamedContext'.",
       {withoutStack: true},
     );
+
+    // warning is deduped so subsequent setting is fine
+    Context.Consumer.displayName = 'ignored';
   });
 });