Skip to content

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Sep 16, 2025

  • Rename apps/website to packages/website
    • The apps directory is going to be for e2e examples. The website can be a private package.
  • Rename apps/examples to apps/platform-tests
    • This app will function a bit like RNTester does for React Native. A place to collect test cases for visual regressions.
  • Add example Expo app
    • This app will function as a demo app for setup with Expo.
  • Add example nextjs app
  • Add examples of default-with-fork components
    • This package will function both as a test for installing a 3P RSD package in Expo/Next, and as a place to share UI code for consistency between the Expo/Next demo apps. It contains platform-specific file forks that Expo/Next should resolve correctly.

cc @MoOx @javascripter

@meta-cla meta-cla bot added the cla signed label Sep 16, 2025
@necolas necolas force-pushed the apps/examples-refactor branch 3 times, most recently from 965b099 to d1929f2 Compare September 16, 2025 04:17
Copy link

github-actions bot commented Sep 16, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

Results Base Patch Ratio
react-strict-dom/dist/web/index.js
· compressed 2,490 2,490 1.00
· minified 8,653 8,653 1.00
react-strict-dom/dist/web/runtime.js
· compressed 855 855 1.00
· minified 2,435 2,435 1.00
react-strict-dom/dist/native/index.js
· compressed 16,195 16,195 1.00
· minified 62,798 62,798 1.00

Copy link

github-actions bot commented Sep 16, 2025

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better.

Results Base Patch Ratio
css.create
· small 1,136,015 1,123,196 0.99 -
· small with units 481,654 494,735 1.03 +
· small with variables 665,989 665,119 1.00 -
· several small 346,612 350,868 1.01 +
· large 201,026 198,969 0.99 -
· large with polyfills 148,283 146,095 0.99 -
· complex 102,594 101,282 0.99 -
· unsupported 211,526 208,802 0.99 -
css.createTheme
· simple theme 222,929 222,644 1.00 -
· polyfill theme 209,703 210,410 1.00 +
css.props
· small 227,912 222,520 0.98 -
· small with units 187,916 186,677 0.99 -
· small with variables 112,895 112,172 0.99 -
· small with variables of units 82,524 82,313 1.00 -
· large 96,596 94,805 0.98 -
· large with polyfills 38,551 38,318 0.99 -
· complex 22,437 22,242 0.99 -
· unsupported 137,932 137,238 0.99 -
· simple merge 158,106 157,344 1.00 -
· wide merge 17,085 17,052 1.00 -
· deep merge 16,827 16,606 0.99 -
· themed merge 32,539 31,764 0.98 -

@necolas necolas force-pushed the apps/examples-refactor branch 3 times, most recently from 95f5e0f to 5d42b50 Compare September 17, 2025 19:52
@necolas necolas changed the title Apps/examples refactor Add Expo and Next examples apps Sep 17, 2025
@necolas necolas force-pushed the apps/examples-refactor branch from 5d42b50 to 07fb3fa Compare September 17, 2025 19:57
@necolas necolas marked this pull request as ready for review September 17, 2025 19:57
@necolas
Copy link
Contributor Author

necolas commented Sep 17, 2025

I love how good the Expo default tooling setup is.

'../../node_modules/example-ui/**/*.js'
]
}),
require('autoprefixer')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Expo SDK 54, we now run autoprefixer automatically using lightningcss which parses all of our CSS.

@necolas necolas merged commit 07fb3fa into main Sep 18, 2025
12 checks passed
"react-strict-dom": "*"
},
"devDependencies": {
"@babel/core": "^7.27.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In SDK 54, @babel/core is also not required anymore. It was a leftover of some weirdness around Metro resolution that we now solved in a better way.

@necolas necolas deleted the apps/examples-refactor branch September 18, 2025 16:16
@necolas
Copy link
Contributor Author

necolas commented Sep 19, 2025

#396 updates the apps to Expo SDK 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants