Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 惠首尔(huiseoul) to showcase #9807

Closed
wants to merge 3 commits into from
Closed

Add 惠首尔(huiseoul) to showcase #9807

wants to merge 3 commits into from

Conversation

johnwook
Copy link
Contributor

@johnwook johnwook commented Sep 8, 2016

It also must be useful considering that the majority
of readers only speak English. So, each app in the showcase should link to either:
1/ An English-language news article discussing the app, built either by a funded startup or for a public company
2/ An English-language technical post on a funded startup or public company blog discussing React Native
For each app in the showcase, use infoLink and infoTitle to reference this content.

  • We wrote a technical post on medium
  • My company was funded, also. Reference #1, #2

- Request to add our service to react native showcase
@ghost
Copy link

ghost commented Sep 8, 2016

By analyzing the blame information on this pull request, we identified @lacker and @alexleventer to be potential reviewers.

@ghost
Copy link

ghost commented Sep 8, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 8, 2016
@ghost
Copy link

ghost commented Sep 8, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2016
@lacker
Copy link
Contributor

lacker commented Sep 8, 2016

Is there an English-language name we could use for the app? Or maybe both English + Chinese in conjunction? Just trying to make sure this page works for an English-language audience.

@johnwook
Copy link
Contributor Author

johnwook commented Sep 9, 2016

@lacker Hi, thanks for prompt reply. Yes we have one. You can call our service Huiseoul(惠首尔). Do you want me to update this PR to use that name? :)

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016
- also removed long-chinese explanation of the app
@ghost
Copy link

ghost commented Sep 9, 2016

@johnwook updated the pull request - view changes

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016
@ghost
Copy link

ghost commented Sep 9, 2016

@johnwook updated the pull request - view changes

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016
@ghost
Copy link

ghost commented Sep 9, 2016

@johnwook updated the pull request - view changes

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016
@lacker
Copy link
Contributor

lacker commented Sep 9, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Sep 9, 2016
@ghost
Copy link

ghost commented Sep 9, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016
@ghost ghost closed this in 2ee910a Sep 10, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants