-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 惠首尔(huiseoul) to showcase #9807
Conversation
johnwook
commented
Sep 8, 2016
•
edited
Loading
edited
- We wrote a technical post on medium
- My company was funded, also. Reference #1, #2
- Request to add our service to react native showcase
By analyzing the blame information on this pull request, we identified @lacker and @alexleventer to be potential reviewers. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Is there an English-language name we could use for the app? Or maybe both English + Chinese in conjunction? Just trying to make sure this page works for an English-language audience. |
@lacker Hi, thanks for prompt reply. Yes we have one. You can call our service |
- also removed long-chinese explanation of the app
@johnwook updated the pull request - view changes |
@johnwook updated the pull request - view changes |
@johnwook updated the pull request - view changes |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
2ee910a