Skip to content

Fixed the diagram in the FBPortForwarding README #8632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cornedor wants to merge 1 commit into from
Closed

Fixed the diagram in the FBPortForwarding README #8632

cornedor wants to merge 1 commit into from

Conversation

@cornedor
Copy link
Contributor

@cornedor cornedor commented Jul 7, 2016

screen shot 2016-07-07 at 17 11 05
screen shot 2016-07-07 at 17 11 12

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 7, 2016

By analyzing the blame information on this pull request, we identified @frantic to be a potential reviewer.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 7, 2016
@ide
Copy link
Contributor

ide commented Jul 7, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 7, 2016
@ghost
Copy link

ghost commented Jul 7, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 5e10d3e Jul 7, 2016
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@cornedor @bubblesunyum
Fixed the diagram in the FBPortForwarding README
a54ae8e 
Summary:
![screen shot 2016-07-07 at 17 11 05](https://cloud.githubusercontent.com/assets/570297/16658236/e3ae8f38-4465-11e6-9e24-2d6a1bf11ac6.png)
![screen shot 2016-07-07 at 17 11 12](https://cloud.githubusercontent.com/assets/570297/16658235/e3ab0fb6-4465-11e6-991b-a4dbcd675322.png)
Closes facebook#8632

Differential Revision: D3529638

fbshipit-source-id: 7d7dba00975d738e32a7340cfe4d270cc4dc7686
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@cornedor
Fixed the diagram in the FBPortForwarding README
ae2e4b8 
Summary:
![screen shot 2016-07-07 at 17 11 05](https://cloud.githubusercontent.com/assets/570297/16658236/e3ae8f38-4465-11e6-9e24-2d6a1bf11ac6.png)
![screen shot 2016-07-07 at 17 11 12](https://cloud.githubusercontent.com/assets/570297/16658235/e3ab0fb6-4465-11e6-991b-a4dbcd675322.png)
Closes facebook#8632

Differential Revision: D3529638

fbshipit-source-id: 7d7dba00975d738e32a7340cfe4d270cc4dc7686
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2022
Open
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
@cornedor @seraj-ahmad
Fixed the diagram in the FBPortForwarding README
12cb1da 
Summary:
![screen shot 2016-07-07 at 17 11 05](https://cloud.githubusercontent.com/assets/570297/16658236/e3ae8f38-4465-11e6-9e24-2d6a1bf11ac6.png)
![screen shot 2016-07-07 at 17 11 12](https://cloud.githubusercontent.com/assets/570297/16658235/e3ab0fb6-4465-11e6-991b-a4dbcd675322.png)
Closes facebook/react-native#8632

Differential Revision: D3529638

fbshipit-source-id: 7d7dba00975d738e32a7340cfe4d270cc4dc7686
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cornedor @facebook-github-bot @ide