Revert PR-7825 snapshot changes #8508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests got broken after facebook#7825, reverting changes Test Plan: ./scritps/objc-test.sh
|
Locally tests are passing, merging now |
|
@facebook-github-bot shipit |
|
By analyzing the blame information on this pull request, we identified @nicklockwood and @feichngr to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 6, 2016
Summary: Tests got broken after facebook/react-native#7825, reverting changes Closes facebook/react-native#8508 Differential Revision: D3503439 Pulled By: bestander fbshipit-source-id: 95b9283371654265234d975e1b0df540f4ef55fa
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Tests got broken after facebook#7825, reverting changes Closes facebook#8508 Differential Revision: D3503439 Pulled By: bestander fbshipit-source-id: 95b9283371654265234d975e1b0df540f4ef55fa
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Tests got broken after facebook#7825, reverting changes Closes facebook#8508 Differential Revision: D3503439 Pulled By: bestander fbshipit-source-id: 95b9283371654265234d975e1b0df540f4ef55fa
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests got broken after #7825, reverting changes
Test Plan:
./scritps/objc-test.sh