Fix typo in NativeModulesIOS.md #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sophiebits
added a commit
that referenced
this pull request
Apr 15, 2015
Fix typo in NativeModulesIOS.md
Contributor
|
Thanks! |
Closed
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
I noticed RN docs mention type "node" in most place (except button, why? no idea). But in practise, it seems codebase has this typed as string, see https://github.com/facebook/react-native/search?p=2&q=accessibilitylabel&unscoped_q=accessibilitylabel You can notice that ios & android implementation explicitly use string (same for the (react-native-)web). The only place we see node in the codebase, is in the deprecated props, see https://github.com/facebook/react-native/blob/408207b356849ca3cefad0ce91a3889e73bd8682/Libraries/DeprecatedPropTypes/DeprecatedImagePropType.js#L34
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.