-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $(inherited) to OTHER_LDFLAGS in xcodeproj template #7927
Closed
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set $(inherited), then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting $(inherited) we are essentially overriding settings provided on project level (rather than target level) as well as .xcconfig level.
By analyzing the blame information on this pull request, we identified @alexeylang and @skozer to be potential reviewers. |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Jun 17, 2016
Summary: This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this ![image](https://cloud.githubusercontent.com/assets/696842/15801450/feb3c036-2a4 Closes facebook#7927 Differential Revision: D3430228 Pulled By: javache fbshipit-source-id: ef453ad2e822726db0159d24ec93e301192e21de
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this ![image](https://cloud.githubusercontent.com/assets/696842/15801450/feb3c036-2a4 Closes facebook#7927 Differential Revision: D3430228 Pulled By: javache fbshipit-source-id: ef453ad2e822726db0159d24ec93e301192e21de
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this ![image](https://cloud.githubusercontent.com/assets/696842/15801450/feb3c036-2a4 Closes facebook#7927 Differential Revision: D3430228 Pulled By: javache fbshipit-source-id: ef453ad2e822726db0159d24ec93e301192e21de
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this ![image](https://cloud.githubusercontent.com/assets/696842/15801450/feb3c036-2a4 Closes facebook/react-native#7927 Differential Revision: D3430228 Pulled By: javache fbshipit-source-id: ef453ad2e822726db0159d24ec93e301192e21de
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Import Started
This pull request has been imported. This does not imply the PR has been approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig)
If we do not set
$(inherited)
, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting$(inherited)
we are essentially overriding settings provided on project level (rather than target level) as well as.xcconfig
level.Test plan (required)
react-native init MyProject cd ios pod init
Now go and add a pod to the
Podfile
, sayAnd try to use it in
AppDelegate.m
Before this change, you'll get errors like this
![image](https://cloud.githubusercontent.com/assets/696842/15801450/feb3c036-2a49-11e6-9174-b4e73c8fbf74.png)
After this change, the build will succeed.