Skip to content

[CameraRoll] support fetching videos from the camera roll #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsierles wants to merge 4 commits into from
Closed

[CameraRoll] support fetching videos from the camera roll #774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
332867b
support fetching videos from the camera roll. Make the default fetch …
jsierles Apr 9, 2015
87a9ce5
Make photos the default camera roll asset type. Define asset types us…
jsierles Apr 9, 2015
21db00e
Merge branch 'master' into camera-roll-video-assets
jsierles Apr 9, 2015
c90a5ce
Fix capitalization of camera roll asset parameter options.
jsierles Apr 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Libraries/CameraRoll/CameraRoll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ var getPhotosParamChecker = createStrictShapeTypeChecker({
* titles.
*/
groupName: ReactPropTypes.string,

/**
* Specifies filter on asset type, like 'all', 'photos' or 'videos'
*/
assetType: ReactPropTypes.string,
Copy link
Contributor

@vjeux vjeux Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make it ReactPropTypes.oneOf(['all', 'photos', 'videos']) instead of writing it in the comments. The comment can say that all is the default

});

/**
Expand Down
14 changes: 12 additions & 2 deletions Libraries/Image/RCTCameraRollManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ - (void)getPhotos:(NSDictionary *)params callback:(RCTResponseSenderBlock)callba
NSString *afterCursor = params[@"after"];
NSString *groupTypesStr = params[@"groupTypes"];
NSString *groupName = params[@"groupName"];
NSString *assetType = params[@"assetType"];
ALAssetsGroupType groupTypes;

if ([groupTypesStr isEqualToString:@"Album"]) {
groupTypes = ALAssetsGroupAlbum;
} else if ([groupTypesStr isEqualToString:@"All"]) {
Expand All @@ -83,15 +85,23 @@ - (void)getPhotos:(NSDictionary *)params callback:(RCTResponseSenderBlock)callba
} else {
groupTypes = ALAssetsGroupSavedPhotos;
}

Copy link
Contributor

@sahrens sahrens Jun 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to remove the trailing whitespace.

BOOL __block foundAfter = NO;
BOOL __block hasNextPage = NO;
BOOL __block calledCallback = NO;
NSMutableArray *assets = [[NSMutableArray alloc] init];

[[RCTImageLoader assetsLibrary] enumerateGroupsWithTypes:groupTypes usingBlock:^(ALAssetsGroup *group, BOOL *stopGroups) {
if (group && (groupName == nil || [groupName isEqualToString:[group valueForProperty:ALAssetsGroupPropertyName]])) {
[group setAssetsFilter:ALAssetsFilter.allPhotos];

if (assetType == nil || [assetType isEqualToString:@"all"]) {
[group setAssetsFilter:ALAssetsFilter.allAssets];
} else if ([assetType isEqualToString:@"photos"]) {
[group setAssetsFilter:ALAssetsFilter.allPhotos];
} else if ([assetType isEqualToString:@"videos"]) {
[group setAssetsFilter:ALAssetsFilter.allVideos];
}

[group enumerateAssetsWithOptions:NSEnumerationReverse usingBlock:^(ALAsset *result, NSUInteger index, BOOL *stopAssets) {
if (result) {
NSString *uri = [(NSURL *)[result valueForProperty:ALAssetPropertyAssetURL] absoluteString];
Expand Down