Automatically configure local IP address for iOS device development #6362

aleclarson · 2016-03-08T15:18:46Z

Fixes #6291, #4351, #4245, #1597, and #883.

It's worth mentioning that I did not change the call to /status because it's in a "Run Script" phase. Any ideas on fixing that as well?

facebook-github-bot · 2016-03-08T15:19:33Z

By analyzing the blame information on this pull request, we identified @foghina, @nicklockwood and @javache to be potential reviewers.

facebook-github-bot · 2016-03-08T15:21:15Z

@aleclarson updated the pull request.

facebook-github-bot · 2016-03-08T15:22:16Z

@aleclarson updated the pull request.

facebook-github-bot · 2016-03-08T15:24:19Z

@aleclarson updated the pull request.

javache · 2016-03-08T15:48:31Z

I'm not a huge fan of doing this automatically, as at some point, it will be very confusing where this IP is coming from, the wrong IP will be used, or people won't find the magic shell scripts embedded in the xcode project.

Kureev · 2016-03-08T16:02:04Z

@aleclarson looks nice 👍

aleclarson · 2016-03-08T16:02:50Z

@javache

Is it worth moving the shell script to a .sh file for easier finding?
Maybe we could have a manually set IP that overrides the automatically set IP?
Necessary fixes to the shell script will appear in the issues over time. 😄

Kureev · 2016-03-08T16:04:13Z

@aleclarson

Maybe we could have a manually set IP that overrides the automatically set IP?

I think it should be something like an optional parameter: react-native run-ios --host=192.168.1.10

aleclarson · 2016-03-08T16:05:24Z

@Kureev Ooh I really like that.

We could also take advantage of NSUserDefaults just like the port uses [standardDefaults integerForKey:@"websocket-executor-port"].

facebook-github-bot · 2016-03-08T16:25:18Z

@aleclarson updated the pull request.

facebook-github-bot · 2016-03-08T16:56:18Z

@aleclarson updated the pull request.

aleclarson · 2016-03-08T17:01:23Z

The recent changes include:

The script that starts the React Packager now uses the automatic IP address.
Combined the IP script and Packager script into local-cli/start_packager.sh.

Changes still needed:

Add --host and --port flags to the run-ios command.
Somehow access the custom host and port inside the start_packager.sh script.

mroswald · 2016-03-10T14:10:21Z

local-cli/start_packager.sh

+echo "// Updated on "`date` >> $HEADER
+echo "" >> $HEADER
+
+ip_address="`ifconfig en0 | grep "inet " | cut -d: -f2 | awk '{print $2}'`"


This depends strongly on your system (only macbooks on wifi, right?). And if you assume that you're on a mac, you could just use ipconfig getifaddr en0

@mroswald I just copied that line from a commit linked by this comment. This has also been discussed in depth in #4245. It can't be ipconfig getifaddr en0 because you might change networks often (eg: you go to a coffee shop, or you use ethernet at work). I doubt what I have is the perfect solution; but as long as there is a way to override the automatic IP, we can use the current solution. If anyone finds a way to make it more robust, just submit a PR.

I still don't fully understand what happens when you have, say, en0 and en1? Does it pick the random one?

Sorry, I haven't tested that scenario. Maybe @christopherdro knows.

@frantic has a good point that this might not work for all cases.

I believe new macs that are only wireless use en0 however, older macs that use en0 when wired in and en1 for wifi.

ipconfig getifaddr en0 is less magical and will be easier to fix in the future. If we want to go the more complex route, we can use ifconfig command to find and store all available interfaces, and somehow offer the user to choose from the list. I don't think it's worth it at this point.

frantic · 2016-03-10T18:11:44Z

Slightly different approach for addressing the same problem: #6345

I guess the main difference is that in #6345 we store the IP address in a file inside the main app's bundle, but here we modify a header file. I guess both have pro's and con's. In Facebook's case we have a copy of RN inside the repo, which means every Xcode build will change the header with the IP and might cause troubles. Using a text file is nice when we consider a potential use case of downloading pre-built binaries (instead of compiling the shell ourselves), in which case it's much easier to swap the IP.

I like that RCTServerUtils also abstracts away the port as well (if we decide to change it at some point).

@javache good point, but I think it's worth it. Now basically everyone has to mess with the IP setting every time they want to test on device. We can solve the 80%-case and have clearer error messages on how to deal with the rest 20%.

facebook-github-bot · 2016-03-13T05:07:18Z

@aleclarson updated the pull request.

facebook-github-bot · 2016-03-14T12:21:16Z

@aleclarson updated the pull request.

facebook-github-bot · 2016-03-14T18:40:43Z

@aleclarson updated the pull request.

aleclarson · 2016-03-14T18:51:53Z

Weird. I haven't updated the pull request in 6 days, but the bot keeps saying I'm updating it. 😯

facebook-github-bot · 2016-04-16T19:56:18Z

@aleclarson updated the pull request.

facebook-github-bot · 2016-04-16T19:59:18Z

@aleclarson updated the pull request.

ghost · 2016-04-17T17:00:27Z

@foghina would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

christopherdro · 2016-04-17T17:17:41Z

Sorry for the late response.

This is what I've been using internally for the last couple months and has been serving us well.

wildlifela@a98fc4d

Then update your AppDelegate.m.

#import "RCTIPAddress.h"

 #if RCT_DEV
      #if TARGET_OS_SIMULATOR
        jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/index.ios.bundle?platform=ios"];
      #else
        NSString *URLString = [NSString stringWithFormat:@"http://%@:8081/index.ios.bundle?platform=ios", LOCAL_IP_ADDRESS ];
        jsCodeLocation = [NSURL URLWithString:URLString];
      #endif
    #else
      jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
    #endif

rauchy · 2016-05-17T07:14:58Z

How about https://www.npmjs.com/package/react-native-network-boot ?

ghost · 2016-05-28T17:00:20Z

@aleclarson do you have any updates for this pull request? It's been a while since the last update so wanted to check in and see if you've looked at the requested changes.

ghost · 2016-05-28T18:25:31Z

@aleclarson updated the pull request.

aleclarson · 2016-05-28T18:59:48Z

I noticed RCTDevMenu has a workaround of its own:

- (NSURL *)packagerURL
{
  NSString *host = [_bridge.bundleURL host];
  if (!host) {
    return nil;
  }

  NSString *scheme = [_bridge.bundleURL scheme];
  NSNumber *port = [_bridge.bundleURL port];
  if (!port) {
    port = @8081; // Packager default port
  }
  return [NSURL URLWithString:[NSString stringWithFormat:@"%@://%@:%@/message?role=shell", scheme, host, port]];
}

If RCTPackagerUtils had access to the RCTBridge, we could just go with that solution.

Otherwise, we can just replace that code with [RCTPackagerUtils URLForPath:].

facebook-github-bot · 2016-05-28T19:08:17Z

@aleclarson updated the pull request.

javache · 2016-05-28T19:15:22Z

Hi @aleclarson, @nathanajah is working on open-sourcing our internal component that provides automatic packager discovery and will incorporate your changes. Thank you for your work on this PR!

aleclarson · 2016-05-28T19:18:43Z

@javache Sounds good!

Summary: Implemented automatic IP detection for iOS, based on #6345 and #6362. As the previous pull requests did, this works by writing the IP address of the host to a file. Closes #8091 Differential Revision: D3427657 Pulled By: javache fbshipit-source-id: 3f534c9b32c4d6fb9615fc2e2c3c3aef421454c5

Summary: Implemented automatic IP detection for iOS, based on facebook#6345 and facebook#6362. As the previous pull requests did, this works by writing the IP address of the host to a file. Closes facebook#8091 Differential Revision: D3427657 Pulled By: javache fbshipit-source-id: 3f534c9b32c4d6fb9615fc2e2c3c3aef421454c5

isaaclem · 2018-09-13T13:01:56Z

Is there any recommended way to handle on running ios devices?

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 8, 2016

aleclarson force-pushed the localIP-PR branch from 562835a to c41f2fc Compare March 8, 2016 15:20

aleclarson force-pushed the localIP-PR branch from c41f2fc to f92879a Compare March 8, 2016 15:21

aleclarson force-pushed the localIP-PR branch from f92879a to 38cc563 Compare March 8, 2016 15:23

aleclarson force-pushed the localIP-PR branch from 38cc563 to f7f9fa8 Compare March 8, 2016 16:25

aleclarson force-pushed the localIP-PR branch from f7f9fa8 to 40ff5c1 Compare March 8, 2016 16:56

mroswald reviewed Mar 10, 2016
View reviewed changes

aleclarson force-pushed the localIP-PR branch from fb191c3 to f216598 Compare April 16, 2016 19:58

frantic added GH Review: needs-revision and removed GH Review: review-needed labels Apr 20, 2016

satya164 added Needs Response from Author and removed GH Review: review-needed labels May 24, 2016

ghost added GH Review: review-needed and removed GH Review: needs-revision labels May 28, 2016

Automatically configure local IP address for iOS device development

4e9d7b1

aleclarson force-pushed the localIP-PR branch from 7c29068 to 4e9d7b1 Compare May 28, 2016 19:07

aleclarson closed this May 28, 2016

nathanajah mentioned this pull request Jun 13, 2016

Implemented automatic IP detection for iOS #8091

Closed

aleclarson deleted the localIP-PR branch June 19, 2016 09:24

v-ahuja mentioned this pull request Feb 21, 2017

Random failing with red-screen when debugging on device v-ahuja/resiShare#1

Closed

Automatically configure local IP address for iOS device development #6362

Automatically configure local IP address for iOS device development #6362

Uh oh!

Conversation

aleclarson commented Mar 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

javache commented Mar 8, 2016

Uh oh!

Kureev commented Mar 8, 2016

Uh oh!

aleclarson commented Mar 8, 2016

Uh oh!

Kureev commented Mar 8, 2016

Uh oh!

aleclarson commented Mar 8, 2016

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

aleclarson commented Mar 8, 2016

Uh oh!

mroswald Mar 10, 2016

Choose a reason for hiding this comment

Uh oh!

aleclarson Mar 10, 2016

Choose a reason for hiding this comment

Uh oh!

frantic Mar 31, 2016

Choose a reason for hiding this comment

Uh oh!

aleclarson Apr 16, 2016

Choose a reason for hiding this comment

Uh oh!

christopherdro Apr 17, 2016

Choose a reason for hiding this comment

Uh oh!

frantic Apr 20, 2016

Choose a reason for hiding this comment

Uh oh!

frantic commented Mar 10, 2016

Uh oh!

facebook-github-bot commented Mar 13, 2016

Uh oh!

facebook-github-bot commented Mar 14, 2016

Uh oh!

facebook-github-bot commented Mar 14, 2016

Uh oh!

aleclarson commented Mar 14, 2016

Uh oh!

facebook-github-bot commented Apr 16, 2016

Uh oh!

facebook-github-bot commented Apr 16, 2016

Uh oh!

ghost commented Apr 17, 2016

Uh oh!

christopherdro commented Apr 17, 2016

Uh oh!

rauchy commented May 17, 2016

Uh oh!

ghost commented May 28, 2016

Uh oh!

ghost commented May 28, 2016

Uh oh!

aleclarson commented May 28, 2016

Uh oh!

facebook-github-bot commented May 28, 2016

Uh oh!

javache commented May 28, 2016

Uh oh!

aleclarson commented May 28, 2016

aleclarson commented Mar 8, 2016 •

edited

Loading