added ArcChat.com Android app to showcase #6267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
By analyzing the blame information on this pull request, we identified @brentvatne, @chirag04 and @mkonicek to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
Hey, looks good! Would you mind moving your app at the top of the list to keep it alphabetical? Also - if you could move the other 2 (at the end) that are not sorted, that would be awesome. I think one of them is my fault as I've shipped it yesterday w/o checking this. Thanks! |
Contributor
|
@liesislukas updated the pull request. |
Contributor
Author
|
here you go 👍 |
Contributor
|
Thanks!! |
Contributor
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:Added http://arcchat.com/ android app https://play.google.com/store/apps/details?id=com.arcchat to showcase https://facebook.github.io/react-native/showcase.html Closes facebook#6267 Differential Revision: D3006203 fb-gh-sync-id: 7ff9d0b6d2536671a5fec1aec081aacfcd4489d3 shipit-source-id: 7ff9d0b6d2536671a5fec1aec081aacfcd4489d3
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added http://arcchat.com/ android app https://play.google.com/store/apps/details?id=com.arcchat to showcase https://facebook.github.io/react-native/showcase.html