[Docs] fix props anchor links #6208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Contributor
Author
|
@vjeux I'm so sorry. I wanted to update PR to fix others anchor links. Take a look on second commit please. |
Contributor
|
@skv-headless updated the pull request. |
skv-headless
force-pushed
the
fix-props-links
branch
from
1fcfbb8 to
b9f35eb
Compare
Contributor
|
@skv-headless updated the pull request. |
Contributor
|
@facebook-github-bot shipit |
skv-headless
force-pushed
the
fix-props-links
branch
from
b9f35eb to
37b7f3c
Compare
Contributor
|
@skv-headless updated the pull request. |
skv-headless
force-pushed
the
fix-props-links
branch
from
37b7f3c to
fb37e18
Compare
Contributor
|
@skv-headless updated the pull request. |
ghost
closed this
in
Contributor
Author
|
@vjeux again I'm sorry. At last update I fixed anchors on support page and clean code a little bit. Could you please ship again? |
Contributor
|
Erg sorry, I was too fast :p I can't shipit again but can you open up a pull request with the changes and i'll make sure to merge them in |
This was referenced Feb 29, 2016
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:All anchor links are broken because of https://github.com/facebook/react-native/blob/master/website/core/Site.js#L37 base tag it means that relative urls won't work. closes facebook#5450 proof  Closes facebook#6208 Differential Revision: D2988892 Pulled By: vjeux fb-gh-sync-id: da8b621af92d792a258812e38ae15f7cf53873ca shipit-source-id: da8b621af92d792a258812e38ae15f7cf53873ca
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All anchor links are broken because of https://github.com/facebook/react-native/blob/master/website/core/Site.js#L37 base tag it means that relative urls won't work.
closes #5450
proof