Skip to content

Add My IP to showcase #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joshbuchea wants to merge 1 commit into from
Closed

Add My IP to showcase #5961

joshbuchea wants to merge 1 commit into from

Conversation

@joshbuchea
Copy link
Contributor

@joshbuchea joshbuchea commented Feb 16, 2016

No description provided.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 16, 2016

By analyzing the blame information on this pull request, we identified @brentvatne, @chirag04 and @mkonicek to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 16, 2016
@joshbuchea
Copy link
Contributor Author

joshbuchea commented Feb 16, 2016

@skevy Here is the new PR

@skevy
Copy link
Contributor

skevy commented Feb 16, 2016

Thanks @joshbuchea!

@skevy
Copy link
Contributor

skevy commented Feb 16, 2016

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 16, 2016

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/963361063758224/int_phab to review.

@ghost ghost closed this in d1dbe2d Feb 16, 2016
@bestander
Copy link
Contributor

bestander commented Feb 16, 2016

this pr broke website generation https://circleci.com/gh/facebook/react-native/2720
The code got merged to master.
Please provide a patch and watch out for ci errors next time you shipit :)

My fault though, we have too many false negatives.

@skevy
Copy link
Contributor

skevy commented Feb 16, 2016

@bestander I did look at that, but I honestly didn't realize it was related :(

Sorry about that. @joshbuchea already submitted a fix, and it's shipping.

@bestander
Copy link
Contributor

bestander commented Feb 17, 2016

👍

pglotov pushed a commit to pglotov/react-native that referenced this pull request Mar 15, 2016
@joshbuchea @pglotov
Add My IP to showcase
a203697 
Summary: Closes facebook#5961

Differential Revision: D2940219

Pulled By: androidtrunkagent

fb-gh-sync-id: 4f9623fb7fe462939982bd98cb789f3ec358509b
shipit-source-id: 4f9623fb7fe462939982bd98cb789f3ec358509b
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshbuchea @facebook-github-bot @skevy @bestander