fix cp command in ReactNativeDependencies.podspec #53136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Job Summary for GradleTest All :: build_android
|
facebook-github-bot
added
the
Shared with Meta
|
/rebase - this comment automatically rebase on top of main |
cipolleschi
approved these changes
Aug 8, 2025
cipolleschi
approved these changes
Aug 8, 2025
cipolleschi
approved these changes
Aug 8, 2025
cipolleschi
approved these changes
Aug 8, 2025
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79990895. |
|
@cipolleschi merged this pull request in 4c570b5. |
|
This pull request was successfully merged by @vonovak in 4c570b5 When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
Summary: When running `RCT_USE_PREBUILT_RNCORE=1 RCT_USE_RN_DEP=1 pod install` I'm getting an error: `cp: framework/packages/react-native/..: File exists` This is not seen consistently by everyone but I've seen in reported one more time at Expo. Could be related to running MacOS 26. Somehow, apparently, the `..` is being treated as a literal directory name and cp is trying to create a directory named `..` inside `framework/packages/react-native/` which is not what we want. Using `/.` avoids that. --- What also seemed to work(around) was to change `mkdir -p framework/packages/react-native` to `mkdir -p framework/packages/` and then `cp` can create the `framework/packages/react-native/..` folder. But this is definitely more confusing. ## Changelog: Pick one each for the category and type tags: [IOS] [FIXED] - fix "file exists" error in `ReactNativeDependencies.podspec` Pull Request resolved: facebook#53136 Test Plan: tested locally, and in CI on older macOS: expo/expo#38631 (the ios build succeeds) Reviewed By: rshest Differential Revision: D79990895 Pulled By: cipolleschi fbshipit-source-id: 44ff9034800d3acd4e55ec39aabfb326382372cb
react-native-bot
pushed a commit
that referenced
this pull request
Aug 27, 2025
Summary: When running `RCT_USE_PREBUILT_RNCORE=1 RCT_USE_RN_DEP=1 pod install` I'm getting an error: `cp: framework/packages/react-native/..: File exists` This is not seen consistently by everyone but I've seen in reported one more time at Expo. Could be related to running MacOS 26. Somehow, apparently, the `..` is being treated as a literal directory name and cp is trying to create a directory named `..` inside `framework/packages/react-native/` which is not what we want. Using `/.` avoids that. --- What also seemed to work(around) was to change `mkdir -p framework/packages/react-native` to `mkdir -p framework/packages/` and then `cp` can create the `framework/packages/react-native/..` folder. But this is definitely more confusing. ## Changelog: Pick one each for the category and type tags: [IOS] [FIXED] - fix "file exists" error in `ReactNativeDependencies.podspec` Pull Request resolved: #53136 Test Plan: tested locally, and in CI on older macOS: expo/expo#38631 (the ios build succeeds) Reviewed By: rshest Differential Revision: D79990895 Pulled By: cipolleschi fbshipit-source-id: 44ff9034800d3acd4e55ec39aabfb326382372cb
|
This pull request was successfully merged by @vonovak in e6e814c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When running
RCT_USE_PREBUILT_RNCORE=1 RCT_USE_RN_DEP=1 pod installI'm getting an error:cp: framework/packages/react-native/..: File existsThis is not seen consistently by everyone but I've seen in reported one more time at Expo. Could be related to running MacOS 26.
Somehow, apparently, the
..is being treated as a literal directory name and cp is trying to create a directory named..insideframework/packages/react-native/which is not what we want. Using/.avoids that.What also seemed to work(around) was to change
mkdir -p framework/packages/react-nativetomkdir -p framework/packages/and thencpcan create theframework/packages/react-native/..folder. But this is definitely more confusing.Changelog:
Pick one each for the category and type tags:
[IOS] [FIXED] - fix "file exists" error in
ReactNativeDependencies.podspecTest Plan:
tested locally, and in CI on older macOS: expo/expo#38631 (the ios build succeeds)