Skip to content

Conversation

@cortinico
Copy link
Contributor

Summary:
This adds a Gradle property called exclusiveEnterpriseRepository
that users can set in their android/gradle.properties as such:

# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for exclusiveEnterpriseRepository to specify an internal Maven mirror.

Differential Revision: D77667573

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77667573

cortinico added a commit to cortinico/react-native that referenced this pull request Jul 2, 2025
Summary:

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Differential Revision: D77667573
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77667573

cortinico added a commit to cortinico/react-native that referenced this pull request Jul 2, 2025
Summary:
Pull Request resolved: facebook#52378

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Differential Revision: D77667573
cortinico added a commit to cortinico/react-native that referenced this pull request Jul 2, 2025
Summary:

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Differential Revision: D77667573
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77667573

cortinico added a commit to cortinico/react-native that referenced this pull request Jul 2, 2025
Summary:
Pull Request resolved: facebook#52378

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Differential Revision: D77667573
cortinico added a commit to cortinico/react-native that referenced this pull request Jul 2, 2025
Summary:

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Reviewed By: mdvacca

Differential Revision: D77667573
Summary:
Pull Request resolved: facebook#52378

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Reviewed By: mdvacca

Differential Revision: D77667573
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77667573

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6cb8dc3.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 3, 2025
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in 6cb8dc3

When will my fix make it into a release? | How to file a pick request?

cortinico added a commit that referenced this pull request Jul 3, 2025
Summary:
Pull Request resolved: #52378

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Reviewed By: mdvacca

Differential Revision: D77667573

fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in 89eff97

When will my fix make it into a release? | How to file a pick request?

@gabrieldonadel
Copy link
Collaborator

@cortinico do we plan on supporting some sort of authentication scheme and credentials for this repository? E.g. expo/expo#26895

@cortinico
Copy link
Contributor Author

@cortinico do we plan on supporting some sort of authentication scheme and credentials for this repository? E.g. expo/expo#26895

Good point. We probably should. Did you get anyone asking this using Expo?

@gabrieldonadel
Copy link
Collaborator

@cortinico do we plan on supporting some sort of authentication scheme and credentials for this repository? E.g. expo/expo#26895

Good point. We probably should. Did you get anyone asking this using Expo?

Not yet, but I image some larger companies may use credentials for their proxies

@cortinico
Copy link
Contributor Author

@cortinico do we plan on supporting some sort of authentication scheme and credentials for this repository? E.g. expo/expo#26895

Good point. We probably should. Did you get anyone asking this using Expo?

Not yet, but I image some larger companies may use credentials for their proxies

I'd suggest we add them as soon as we get a request for it. Otherwise we're basically re-implementing the whole Gradle Repository API just for the sake of 'potential users'

@gabrieldonadel
Copy link
Collaborator

I'd suggest we add them as soon as we get a request for it. Otherwise we're basically re-implementing the whole Gradle Repository API just for the sake of 'potential users'

Sounds good to me!

gabrieldonadel added a commit to expo/expo that referenced this pull request Jul 7, 2025
# Why

facebook/react-native#52378 introduced a new
gradle property called `exclusiveEnterpriseRepository`, allowing users
to remove all the existing Maven repositories and only use the specified
internal mirror. We should support customizing it through
expo-build-properties

# How

Add support for setting Android's exclusiveMavenMirror gradle property

# Test Plan

Added tests and ran prebuild inside sandbox with and without the
exclusiveMavenMirror option

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
-->

- [ ] I added a `changelog.md` entry and rebuilt the package sources
according to [this short
guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
fabriziocucci pushed a commit that referenced this pull request Jul 9, 2025
Summary:
Pull Request resolved: #52378

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Reviewed By: mdvacca

Differential Revision: D77667573

fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in 58a4c2f

When will my fix make it into a release? | How to file a pick request?

cipolleschi pushed a commit that referenced this pull request Jul 24, 2025
Summary:
Pull Request resolved: #52378

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Reviewed By: mdvacca

Differential Revision: D77667573

fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
cipolleschi pushed a commit that referenced this pull request Aug 13, 2025
Summary:
Pull Request resolved: #52378

This adds a Gradle property called `exclusiveEnterpriseRepository`
that users can set in their `android/gradle.properties` as such:

```diff
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

+exclusiveEnterpriseRepository=https://my.internal.proxy.net/
```

This will remove all the existing Maven repositories and only use the internal mirror they have.

Changelog:
[Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror.

Reviewed By: mdvacca

Differential Revision: D77667573

fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants