Skip to content

Make EventDispatcherImpl internal #52154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 2 commits into from
Closed

Make EventDispatcherImpl internal #52154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a3e140
Convert `EventDispatcherImpl` to Kotlin
cortinico Jun 23, 2025
51938af
Make `EventDispatcherImpl` internal (#52154)
cortinico Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4866,20 +4866,6 @@ public abstract interface class com/facebook/react/uimanager/events/EventDispatc
public abstract fun removeListener (Lcom/facebook/react/uimanager/events/EventDispatcherListener;)V
}

public class com/facebook/react/uimanager/events/EventDispatcherImpl : com/facebook/react/bridge/LifecycleEventListener, com/facebook/react/uimanager/events/EventDispatcher {
public fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;)V
public fun addBatchEventDispatchedListener (Lcom/facebook/react/uimanager/events/BatchEventDispatchedListener;)V
public fun addListener (Lcom/facebook/react/uimanager/events/EventDispatcherListener;)V
public fun dispatchAllEvents ()V
public fun dispatchEvent (Lcom/facebook/react/uimanager/events/Event;)V
public fun onCatalystInstanceDestroyed ()V
public fun onHostDestroy ()V
public fun onHostPause ()V
public fun onHostResume ()V
public fun removeBatchEventDispatchedListener (Lcom/facebook/react/uimanager/events/BatchEventDispatchedListener;)V
public fun removeListener (Lcom/facebook/react/uimanager/events/EventDispatcherListener;)V
}

public abstract interface class com/facebook/react/uimanager/events/EventDispatcherListener {
public abstract fun onEventDispatch (Lcom/facebook/react/uimanager/events/Event;)V
}
Expand Down
2 changes: 1 addition & 1 deletion ...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/Event.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public abstract class Event<T : Event<T>> {
* Two events will only ever try to be coalesced if they have the same event name, view id, and
* coalescing key.
*/
public open fun coalesce(otherEvent: Event<T>?): Event<T>? =
public open fun coalesce(otherEvent: Event<*>?): Event<*>? =
if (timestampMs >= otherEvent?.timestampMs ?: 0) this else otherEvent

/**
Expand Down
Loading
Loading