Remove dtslint from type tests #51382
Closed
+64
−884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff replaces `dtslint` which is obsolete and [It is not intended to be used on its own, but as part of the definitelytyped set of packages](https://github.com/microsoft/dtslint) in favor of `tsc` type tests. It's probably not necessary to have `test-typescript-offline` as tsc does that out of the box but doesn't test with multiple TS versions. Changelog: [Internal] Differential Revision: D74804967
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74804967 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 16, 2025
Summary: This diff replaces `dtslint` which is obsolete and [It is not intended to be used on its own, but as part of the definitelytyped set of packages](https://github.com/microsoft/dtslint) in favor of `tsc` type tests. It's probably not necessary to have `test-typescript-offline` as tsc does that out of the box but doesn't test with multiple TS versions. Changelog: [Internal] Differential Revision: D74804967
|
This pull request has been merged in 2e0c2c6. |
|
This pull request was successfully merged by @coado in 2e0c2c6 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: #51382 This diff replaces `dtslint` which is obsolete and [It is not intended to be used on its own, but as part of the definitelytyped set of packages](https://github.com/microsoft/dtslint) in favor of `tsc` type tests. It's probably not necessary to have `test-typescript-offline` as tsc does that out of the box but doesn't test with multiple TS versions. Changelog: [Internal] Reviewed By: huntie Differential Revision: D74804967 fbshipit-source-id: 4c581ba5debf6fd0bb8dcddbb95f3c85b05082d4
|
This pull request was successfully merged by @coado in f9a851f When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: #51382 This diff replaces `dtslint` which is obsolete and [It is not intended to be used on its own, but as part of the definitelytyped set of packages](https://github.com/microsoft/dtslint) in favor of `tsc` type tests. It's probably not necessary to have `test-typescript-offline` as tsc does that out of the box but doesn't test with multiple TS versions. Changelog: [Internal] Reviewed By: huntie Differential Revision: D74804967 fbshipit-source-id: 4c581ba5debf6fd0bb8dcddbb95f3c85b05082d4
|
This pull request was successfully merged by @coado in 60f172c When will my fix make it into a release? | How to file a pick request? |
cipolleschi
added a commit
that referenced
this pull request
Jun 4, 2025
Co-authored-by: Dawid Małecki <[email protected]> resolved: #51382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff replaces
dtslintwhich is obsolete and It is not intended to be used on its own, but as part of the definitelytyped set of packages in favor oftsctype tests.It's probably not necessary to have
test-typescript-offlineas tsc does that out of the box but doesn't test with multiple TS versions.Changelog:
[Internal]
Differential Revision: D74804967