Skip to content

Refactor MutationObserver.disconnect #51128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+10 −26
Closed

Refactor MutationObserver.disconnect #51128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 10 additions & 26 deletions packages/react-native/src/private/webapis/mutationobserver/MutationObserver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,39 +132,23 @@ export default class MutationObserver {
}
}

_unobserve(target: ReactNativeElement): void {
if (!(target instanceof ReactNativeElement)) {
throw new TypeError(
"Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'ReactNativeElement'.",
);
}

if (!this._observationTargets.has(target)) {
return;
}

const mutationObserverId = this._mutationObserverId;
if (mutationObserverId == null) {
return;
}

MutationObserverManager.unobserve(mutationObserverId, target);
this._observationTargets.delete(target);

if (this._observationTargets.size === 0) {
MutationObserverManager.unregisterObserver(mutationObserverId);
this._mutationObserverId = null;
}
}

/**
* Tells the observer to stop watching for mutations.
* The observer can be reused by calling its `observe()` method again.
*/
disconnect(): void {
const mutationObserverId = this._mutationObserverId;
if (mutationObserverId == null) {
return;
}

for (const target of this._observationTargets.keys()) {
this._unobserve(target);
MutationObserverManager.unobserve(mutationObserverId, target);
this._observationTargets.delete(target);
}

MutationObserverManager.unregisterObserver(mutationObserverId);
this._mutationObserverId = null;
}

_getOrCreateMutationObserverId(): MutationObserverId {
Expand Down
Loading