Update React Native shims to use export syntax (#31426) #47551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65672576 |
…book#47551) Summary: ## Summary I'm working to get the main `react-native` package parsable by modern Flow tooling (both `flow-bundler`, `flow-api-translator`), and one blocker is legacy `module.exports` syntax. This diff updates files which are [synced to `react-native`](https://github.com/facebook/react-native/tree/main/packages/react-native/Libraries/Renderer/shims) from this repo. ## How did you test this change? Files were pasted into `react-native-github` under fbsource, where Flow validates ✅. DiffTrain build for [5c56b873efb300b4d1afc4ba6f16acf17e4e5800](facebook/react@5c56b87) Test Plan: Sandcastle tests Reviewed By: sammy-SC Differential Revision: D65672576 Pulled By: huntie
huntie
force-pushed
the
export-D65672576
branch
from
265b3e8 to
78a2702
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65672576 |
|
This pull request was successfully merged by @sammy-SC in 3a41086 When will my fix make it into a release? | How to file a pick request? |
j-piasecki
pushed a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Dec 13, 2024
## Description * 54710a6 - Added `sourceSets` to the package due to changes in ViewManager function signatures, which are no longer nullable * a20adca - Updated to reflect changes in facebook/react-native#47551, `findHostInstance_DEPRECATED` is now a property of the `default` object instead of being a named export. Modified implementation reads from default and fall back to named export as needed * ac7e786 - Similar change to the software-mansion/react-native-svg#2572 that uses new API to create an association map between JS components and their native implementations, avoiding `codegen` crawling through the entire filesystem for `.mm` files. ## Test plan App with React Native 0.77 (like #3277) should compile and work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
I'm working to get the main
react-nativepackage parsable by modernFlow tooling (both
flow-bundler,flow-api-translator), and oneblocker is legacy
module.exportssyntax. This diff updates files whichare synced to
react-nativefrom this repo.
How did you test this change?
Files were pasted into
react-native-githubunder fbsource, where Flowvalidates ✅.
DiffTrain build for 5c56b873efb300b4d1afc4ba6f16acf17e4e5800
Differential Revision: D65672576
Pulled By: huntie