add all keyboard types for keyboardType enum prop #474
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Just realized that this might not be ideal because some of these keyboard types are iOS-specific. What's the correct way to implement these while separating platforms? Is it to subclass TextInput and make TextInputIOS that supports these different styles, along with the returnKeyType property? |
Contributor
|
This was added in #265. |
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
* Added missing code The example was not working at all. There was a lot of code missing in order to make it work. I added the missing code. * Added one more line Forgot `new MainReactPackage()` in `MainApplication.java` * Changed singlequotes to double quotes in java
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
tido64
pushed a commit
to tido64/react-native
that referenced
this pull request
Jul 8, 2020
* Fixing OS specific failure in publish task * Adding publish verfification into the PR job * Adding some comments. * Removing the diagnostic logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the entire suite of keyboardTypes to the enum.
I matched the enums with the constants (
UIKeyboardTypeNumbersAndPunctuationbecomesnumbersAndPunctuation).I also added shortcut enums for the popular and verbose names. (
ascii,number,phone, etc).