Add utf16 method to JSI #47356
Closed
Add utf16 method to JSI #47356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64918244 |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Nov 1, 2024
Summary: Add utf16 method to JSI. This change will add the default implementation for all VMs by calling UTF8 and manually convert it to UTF16. A later change will be added for Hermes to use internal VM information to get the UTF16 string. Changelog: [Internal] Reviewed By: neildhar Differential Revision: D64918244
tsaichien
force-pushed
the
export-D64918244
branch
from
946f49c to
bfd6491
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64918244 |
Summary: Add utf16 method to JSI. This change will add the default implementation for all VMs by calling UTF8 and manually convert it to UTF16. A later change will be added for Hermes to use internal VM information to get the UTF16 string. Changelog: [Internal] Reviewed By: neildhar Differential Revision: D64918244
tsaichien
force-pushed
the
export-D64918244
branch
from
bfd6491 to
85e18c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64918244 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 1, 2024
Summary: X-link: facebook/react-native#47356 Add utf16 method to JSI. This change will add the default implementation for all VMs by calling UTF8 and manually convert it to UTF16. A later change will be added for Hermes to use internal VM information to get the UTF16 string. Changelog: [Internal] Reviewed By: neildhar Differential Revision: D64918244 fbshipit-source-id: 6fc0c44fc397c2f8bb40a4262596b178ee4f1f29
|
This pull request has been merged in 6ab7b70. |
|
This pull request was successfully merged by Chi Tsai in 6ab7b70 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 1, 2024
Summary: X-link: facebook/react-native#47356 Add utf16 method to JSI. This change will add the default implementation for all VMs by calling UTF8 and manually convert it to UTF16. A later change will be added for Hermes to use internal VM information to get the UTF16 string. Changelog: [Internal] Reviewed By: neildhar Differential Revision: D64918244 fbshipit-source-id: 6fc0c44fc397c2f8bb40a4262596b178ee4f1f29
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add utf16 method to JSI. This change will add the default implementation
for all VMs by calling UTF8 and manually convert it to UTF16. A later
change will be added for Hermes to use internal VM information to get
the UTF16 string.
Changelog: [Internal]
Reviewed By: neildhar
Differential Revision: D64918244