[Android] Enable 16KB page size binaries for RN libraries + hermes #47042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64446876 |
alanleedev
added a commit
to alanleedev/hermes
that referenced
this pull request
Oct 31, 2024
Summary: X-link: facebook/react-native#47042 Add native build flags to support 16KB page size - https://developer.android.com/guide/practices/page-sizes#compile-r27-higher Changelog: [Android][Added] add cmake arguments to support 16KB page size for native libraries Differential Revision: D64446876
Summary: X-link: facebook/hermes#1557 Add native build flags to support 16KB page size - https://developer.android.com/guide/practices/page-sizes#compile-r27-higher Changelog: [Android][Added] add cmake arguments to support 16KB page size for native libraries Differential Revision: D64446876
alanleedev
force-pushed
the
export-D64446876
branch
from
98aa048 to
b9ce382
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64446876 |
alanleedev
added a commit
to alanleedev/hermes
that referenced
this pull request
Oct 31, 2024
Summary: X-link: facebook/react-native#47042 Add native build flags to support 16KB page size - https://developer.android.com/guide/practices/page-sizes#compile-r27-higher Changelog: [Android][Added] add cmake arguments to support 16KB page size for native libraries Differential Revision: D64446876
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 1, 2024
Summary: Pull Request resolved: #1557 X-link: facebook/react-native#47042 Add native build flags to support 16KB page size - https://developer.android.com/guide/practices/page-sizes#compile-r27-higher Changelog: [Android][Added] add cmake arguments to support 16KB page size for native libraries Reviewed By: cortinico Differential Revision: D64446876 fbshipit-source-id: 5c6b7874a8837c7ebc9b3e9267ce11fb152bf535
|
This pull request has been merged in 65cdd5b. |
|
This pull request was successfully merged by @alanleedev in 65cdd5b When will my fix make it into a release? | How to file a pick request? |
alanleedev
changed the title
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 14, 2024
Summary: Original Author: [email protected] Original Git: e3aec0f Original Reviewed By: cortinico Original Revision: D64446876 Pull Request resolved: #1557 X-link: facebook/react-native#47042 Add native build flags to support 16KB page size - https://developer.android.com/guide/practices/page-sizes#compile-r27-higher Changelog: [Android][Added] add cmake arguments to support 16KB page size for native libraries Reviewed By: mattbfb Differential Revision: D65787621 fbshipit-source-id: c230966f1cf536233c265c1c2dfecdf2d9a42ed6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add native build flags to support 16KB page size
Changelog:
[Android][Added] add cmake arguments to support 16KB page size for native libraries
Differential Revision: D64446876