Appearance: Cache colorScheme in JavaScript
#46122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Straightforward migration of the `Appearance` module to use ESM named exports. Changelog: [Internal] Reviewed By: TheSavior Differential Revision: D61567882
Summary:
Updates `Appearance` on Android to supply the native module to `NativeEventEmitter` so that the native listener count can be managed like it is on iOS.
This was previously required by macOS and iOS. Android and Windows also already implement:
```
interface NativeModule {
addListener(eventType: string): void;
removeListeners(count: number): void;
}
```
So we should start passing `NativeAppearance` into the `NativeEventEmitter` constructor across all platforms.
Changelog:
[Internal]
Reviewed By: TheSavior
Differential Revision: D61567883
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61567880 |
Summary: Currently, the implementation of `Appearance` duplicates the validation logic of string `colorScheme` values multiple times. This leads to more complicated code and also unnecessary work in certain edge cases (e.g. when `NativeAppearance` is not registered). This refactors `Appearance` to be simpler and to do less work. I've also configured `NativeAppearance.setColorScheme` to be non-nullable because it has existed since 2023. Changelog: [Internal] Differential Revision: D61567881
|
This pull request was exported from Phabricator. Differential Revision: D61567880 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Aug 21, 2024
Summary: Pull Request resolved: facebook#46122 Implements a JavaScript cache for `colorScheme` in the `Appearance` module, so that we avoid potentially expensive and unnecessary native property accesses. Changelog: [General][Changed] - Improved `Appearance.getColorScheme` performance Reviewed By: rickhanlonii Differential Revision: D61567880
yungsters
force-pushed
the
export-D61567880
branch
from
c45a303 to
5e84eac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61567880 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Aug 21, 2024
Summary: Pull Request resolved: facebook#46122 Implements a JavaScript cache for `colorScheme` in the `Appearance` module, so that we avoid potentially expensive and unnecessary native property accesses. Changelog: [General][Changed] - Improved `Appearance.getColorScheme` performance Reviewed By: rickhanlonii Differential Revision: D61567880
yungsters
force-pushed
the
export-D61567880
branch
from
5e84eac to
8a4ee9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61567880 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Aug 21, 2024
Summary: Pull Request resolved: facebook#46122 Implements a JavaScript cache for `colorScheme` in the `Appearance` module, so that we avoid potentially expensive and unnecessary native property accesses. Changelog: [General][Changed] - Improved `Appearance.getColorScheme` performance Reviewed By: rickhanlonii Differential Revision: D61567880
yungsters
force-pushed
the
export-D61567880
branch
from
8a4ee9f to
34a7140
Compare
Summary: Pull Request resolved: facebook#46122 Implements a JavaScript cache for `colorScheme` in the `Appearance` module, so that we avoid potentially expensive and unnecessary native property accesses. Changelog: [General][Changed] - Improved `Appearance.getColorScheme` performance Reviewed By: rickhanlonii Differential Revision: D61567880
|
This pull request was exported from Phabricator. Differential Revision: D61567880 |
yungsters
force-pushed
the
export-D61567880
branch
from
34a7140 to
92f8f7a
Compare
|
This pull request has been merged in 8f0f50f. |
tpaksu
reviewed
Nov 19, 2024
| } | ||
| let colorScheme = null; | ||
| if (NativeAppearance != null) { | ||
| if (appearance == null) { |
There was a problem hiding this comment.
Sorry to intervene, but I think I found a bug here, appearance.colorScheme can be also null here, which is not checked.
Reason: When I set the color scheme to null with setColorScheme, the next call to getColorScheme returns null because of that missing condition preventing the colorScheme to get reset with the system color scheme, which in the end causes the function to return null.
There was a problem hiding this comment.
Thanks @sangonz193 for the comment and the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implements a JavaScript cache for
colorSchemein theAppearancemodule, so that we avoid potentially expensive and unnecessary native property accesses.Changelog:
[General][Changed] - Improved
Appearance.getColorSchemeperformanceReviewed By: rickhanlonii
Differential Revision: D61567880