-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move timing definitions to a specific target #45492
Conversation
This pull request was exported from Phabricator. Differential Revision: D59820241 |
This pull request was exported from Phabricator. Differential Revision: D59820241 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
b2ffa50
to
08b8c19
Compare
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
08b8c19
to
a73cbb9
Compare
This pull request was exported from Phabricator. Differential Revision: D59820241 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D59820241 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
a73cbb9
to
49c2437
Compare
This pull request was exported from Phabricator. Differential Revision: D59820241 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
49c2437
to
6ea5f2a
Compare
This pull request was exported from Phabricator. Differential Revision: D59820241 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
6ea5f2a
to
c3722ac
Compare
This pull request was exported from Phabricator. Differential Revision: D59820241 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
c3722ac
to
7dab8ca
Compare
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
7dab8ca
to
07066a5
Compare
This pull request was exported from Phabricator. Differential Revision: D59820241 |
Base commit: c82edec |
This pull request was exported from Phabricator. Differential Revision: D59820241 |
07066a5
to
a81e93c
Compare
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
This pull request was exported from Phabricator. Differential Revision: D59820241 |
a81e93c
to
9bf1451
Compare
This pull request has been merged in dffc156. |
This pull request was successfully merged by @rubennorte in dffc156 When will my fix make it into a release? | How to file a pick request? |
Summary:
Changelog: [internal]
When testing the changes in #45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto).
Taking a closer look, I realized that I wasn't doing the conversion between times and durations from
chrono
andDOMHighResTimeStamp
(adouble
) correctly, and we're doing this conversion very often.This moves the definition of
DOMHighResTimeStamp
to its own library and adds conversion methods to make sure we don't make this mistake in the future.Differential Revision: D59820241