Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hermes] Bump Hermes #45220

Merged
merged 2 commits into from
Jul 1, 2024
Merged

[Hermes] Bump Hermes #45220

merged 2 commits into from
Jul 1, 2024

Commits on Jun 28, 2024

  1. [Hermes] Bump Hermes

    @cipolleschi
    cipolleschi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d818083 View commit details
    Browse the repository at this point in the history

  2. Implement queueMicrotask and drainMicrotasks in JSC 

    Summary:
Changelog: [internal]

## Context

We want to enable the new React Native event loop by default for all users on the new RN architecture (on the bridgeless initialization path more concretely), which requires support for microtasks in all the JS engines that the support (Hermes already has it, JSC doesn't).

## Changes

This adds initial support for microtasks in JSC, so we can schedule and execute microtasks in this runtime.

One limitation about this approach is that, AFAIK, the public API for JSC doesn't allow us to customize its internal microtask queue or specify the method to be used by its built-in `Promise` or native `async function`, so we're forced to continue using a polyfill in that case (which uses `setImmediate` that will be mapped to `queueMicrotask`).

Reviewed By: NickGerleman

Differential Revision: D54302534

fbshipit-source-id: 47f71620344a81bc6624917f77452106ffbf55a3
    @rubennorte @cipolleschi
    rubennorte authored and cipolleschi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3f558bd View commit details
    Browse the repository at this point in the history