Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][GHA] Fix publish-release regex #44921

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jun 13, 2024

Summary:

The publish_release job is broken due to the initial regex. This change would like to fix it

Changelog:

[Internal] - Fix publish_release job

Test Plan:

Test on PR

Screenshot 2024-06-13 at 08 51 59

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 13, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-publish-release-workflow branch 7 times, most recently from 4d275ee to 2481f01 Compare June 13, 2024 07:51
@cipolleschi cipolleschi marked this pull request as ready for review June 13, 2024 07:52
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-publish-release-workflow branch from 2481f01 to f359f3a Compare June 13, 2024 07:52
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,364,335 -13
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,569,571 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b19bf2b
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 13, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 9fe9f03.

Copy link

This pull request was successfully merged by @cipolleschi in 9fe9f03.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants