Implement new HostTargetMetadata fields (iOS) #44893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A refactor moving `SessionMetadata` (now renamed as `HostTargetMetadata`) out of `inspectorTarget->connect()` calls into a `HostTargetDelegate::getMetadata` method. This provides a cleaner interface and location for extending metadata fields in future. Changelog: [Internal] Differential Revision: D58288491
Summary: Adds the new CDP domain `ReactNativeApplication`, with the following messages: - `ReactNativeApplication.enable` (method) — Sent by the connected frontend to enable features under this domain. - `ReactNativeApplication.metadataUpdated` (event) — Sent by the backend containing a metadata object about the host. We intend to use this for displaying richer information in the debugger frontend, such as device information and React Native version. Changelog: [General][Added] - Add `ReactNativeApplication.[enable,metadataUpdated]` CDP messages for reading host metadata Differential Revision: D58288490
Summary: Adds the following debugger metadata fields (sent over the `ReactNativeApplication.metadataUpdated` CDP event), and implements these on iOS (Bridge and Bridgeless). - `appIdentifier` - `deviceName` - `platform` - `reactNativeVersion` Changelog: [Internal] Differential Revision: D58288489
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58288489 |
Base commit: 42f136d |
|
This pull request has been merged in 14914bd. |
|
This pull request has been reverted by 11e5394. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds the following debugger metadata fields (sent over the
ReactNativeApplication.metadataUpdatedCDP event), and implements these on iOS (Bridge and Bridgeless).appIdentifierdeviceNameplatformreactNativeVersionChangelog: [Internal]
Differential Revision: D58288489