Do not passthrough logbox errors that already have a component stack #44888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58441017 |
…acebook#44888) Summary: Pull Request resolved: facebook#44888 In facebook/react#29839 we removed the `Warning: ` prefix. This PR replaces the special cases in LogBox for `Warning: ` to use the presence of a component stack instead. This is what LogBox really cares about anyway, since the reason to let errors pass through to the exception manager is to let DevTools add the component stacks. Changelog: [General] [Fix] Fix logbox reporting for React errors Differential Revision: D58441017
|
This pull request was exported from Phabricator. Differential Revision: D58441017 |
rickhanlonii
force-pushed
the
export-D58441017
branch
from
e0e64e5
to
764c98f
Compare
|
This pull request has been merged in 64e6721. |
|
This pull request was successfully merged by @yungsters in 64e6721. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In facebook/react#29839 we removed the
Warning:prefix. This PR replaces the special cases in LogBox forWarning:to use the presence of a component stack instead. This is what LogBox really cares about anyway, since the reason to let errors pass through to the exception manager is to let DevTools add the component stacks.Changelog: [General] [Fix] Fix logbox reporting for React errors
Differential Revision: D58441017