Cleanup accessibility checks #44885
Closed
Cleanup accessibility checks #44885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58390430 |
|
This pull request was exported from Phabricator. Differential Revision: D58390430 |
pieterv
added a commit
to pieterv/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44885 Cleanup accessibility related props checks to ensure we are doing the minimal amount of work. e.g. reduce duplicate `null` checks and shift checks to conditional branches that use them. Changelog: [Internal] Reviewed By: javache Differential Revision: D58390430
pieterv
force-pushed
the
export-D58390430
branch
from
78213f3
to
d5aa617
Compare
Base commit: bfb3b70 |
Differential Revision: D58386781
Summary: Pull Request resolved: facebook#44885 Cleanup accessibility related props checks to ensure we are doing the minimal amount of work. e.g. reduce duplicate `null` checks and shift checks to conditional branches that use them. Changelog: [Internal] Reviewed By: javache Differential Revision: D58390430
|
This pull request was exported from Phabricator. Differential Revision: D58390430 |
pieterv
force-pushed
the
export-D58390430
branch
from
d5aa617
to
3a2a4d6
Compare
|
This pull request has been merged in 54997e4. |
|
This pull request was successfully merged by @pieterv in 54997e4. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cleanup accessibility related props checks to ensure we are doing the minimal amount of work. e.g. reduce duplicate
nullchecks and shift checks to conditional branches that use them.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D58390430