Migration RN Alert Dialog to androidx (#44494) #44880
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #44494
Migrates the
AlertFragment
fromandroid.app.AlertDialog
toandroidx.appcompat.app.AlertDialog
. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, alignment of buttons, etc.For consideration
android
namespace, meaning themes can now be specified asalertDialogTheme
rather thanandroid:alertDialogTheme
.Theme.AppCompat
. Creation of any activities which do not have a descendant of this style will result in anIllegalStateException
: https://www.internalfb.com/intern/signalinfra/exception_owners/?mid=5ee93f6ecd59f3d8ad82a78c213ea016&result_id=16044073705339118.281475102518721.1715097866Changelog:
[Android] [Changed] - Migrated
AlertFragment
dialog builder to useandroidx.appcompat
Reviewed By: zeyap
Differential Revision: D57019423
Summary:
Changelog:
Test Plan: