Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][GHA] Move HelloWorld jobs from CCI to GHA #44875

Closed

Conversation

cipolleschi
Copy link
Contributor

Summary:

This change migrates the GHA template jobs to the HelloWorld package for iOS.

Changelog:

[Internal] - Move iOS template jobs to HelloWorld

Test Plan:

GHA are green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 11, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/move-template-jobs-to-helloworld branch from 27d2001 to 9de2b12 Compare June 11, 2024 15:05
@cipolleschi cipolleschi force-pushed the cipolleschi/move-template-jobs-to-helloworld branch 10 times, most recently from 1e8f54f to 807b6a9 Compare June 11, 2024 16:59
@cipolleschi
Copy link
Contributor Author

tests are green but:

  1. Caches are not working. 😕
  2. Hermes is built from source in the helloworld template. 😞

@analysis-bot
Copy link

analysis-bot commented Jun 11, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,364,275 -7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,569,528 +1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 18be49e
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/move-template-jobs-to-helloworld branch 13 times, most recently from e364352 to 305e71e Compare June 12, 2024 08:51
@cipolleschi cipolleschi force-pushed the cipolleschi/move-template-jobs-to-helloworld branch 6 times, most recently from dfae0f3 to 61bceaa Compare June 12, 2024 09:59
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/move-template-jobs-to-helloworld branch from 61bceaa to 9828c5b Compare June 12, 2024 16:09
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 12, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in ae7d543.

Copy link

This pull request was successfully merged by @cipolleschi in ae7d543.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants