Format code-workspace file, clarify use of .vscode/ dir #44874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58413581 |
huntie
changed the title
…nore Summary: While reviewing facebook/react#29830, I noticed this file was committed with tab indentation in React Native. I have also used the `.gitignore` entry to clarify how `react-native.code-workspace` interacts with an optional user `.vscode/` config directory. Note: The `json-stringify` parser can be used with Prettier 3+ only, so we use `json` instead. Changelog: [Internal] Differential Revision: D58413581
|
This pull request was exported from Phabricator. Differential Revision: D58413581 |
huntie
changed the title
Base commit: 3c3c687 |
|
This pull request has been merged in 53dda9e. |
|
This pull request was successfully merged by @huntie in 53dda9e. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While reviewing facebook/react#29830, I noticed this file was committed with tab indentation in React Native. I have also used the
.gitignoreentry to clarify howreact-native.code-workspaceinteracts with an optional user.vscode/config directory.Note: The
json-stringifyparser can be used with Prettier 3+ only, so we usejsoninstead.Changelog: [Internal]
Differential Revision: D58413581