Fix test_android_template #44871
Closed
Fix test_android_template #44871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This re-enables and fix `test_android_template`. The problem was that we were invoking `yarn install` inside the template after we already installed with `npm install --registry`. So this was invalidating the Verdaccio setup and effectively fetching packages from NPM Changelog: [Internal] [Changed] - Fix test_android_template Differential Revision: D58407941
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58407941 |
Base commit: b0c0bb4 |
|
This pull request was successfully merged by @cortinico in 2867d66. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This re-enables and fix
test_android_template.The problem was that we were invoking
yarn installinside the template after we already installed withnpm install --registry.So this was invalidating the Verdaccio setup and effectively fetching packages from NPM
Changelog:
[Internal] [Changed] - Fix test_android_template
Differential Revision: D58407941