Add VisionOS support to GHA nightlies #44855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We recently landed a change that added support for VisionOS in the general test case for GHA but we forgot to include nightlies. This change takes the same changes applied to [this file](https://github.com/facebook/react-native/pull/44691/files#diff-12d2c3c126fcc84106dce4b6d2be2220f018661b111a5382ad6effc1047f66aeR114-R368) and applies them to the nightlies. ## Changelog: [Internal] - Add GHA nightlies support for VisionOS Reviewed By: huntie Differential Revision: D58358115
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58358115 |
Base commit: 924fb3d |
|
This pull request has been merged in 01822eb. |
|
This pull request was successfully merged by @cipolleschi in 01822eb. When will my fix make it into a release? | How to file a pick request? |
okwasniewski
pushed a commit
to okwasniewski/react-native
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: facebook#44855 We recently landed a change that added support for VisionOS in the general test case for GHA but we forgot to include nightlies. This change takes the same changes applied to [this file](https://github.com/facebook/react-native/pull/44691/files#diff-12d2c3c126fcc84106dce4b6d2be2220f018661b111a5382ad6effc1047f66aeR114-R368) and applies them to the nightlies. [Internal] - Add GHA nightlies support for VisionOS Reviewed By: huntie Differential Revision: D58358115 fbshipit-source-id: 577f62e53fb530bc534ba98508801a6970aef095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We recently landed a change that added support for VisionOS in the general test case for GHA but we forgot to include nightlies.
This change takes the same changes applied to this file and applies them to the nightlies.
Changelog:
[Internal] - Add GHA nightlies support for VisionOS
Reviewed By: huntie
Differential Revision: D58358115