Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import of com.facebook.react.ReactSettingsExtension #44850

Closed
wants to merge 1 commit into from

Commits on Jun 10, 2024

  1. Remove import of com.facebook.react.ReactSettingsExtension (faceboo…

    …k#44850)
    
    Summary:
    Pull Request resolved: facebook#44850
    
    I'm removing this line from settings.gradle:
    ```
    import com.facebook.react.ReactSettingsExtension
    ```
    and just using a fully qualified class name in the `configure{}` block
    as imports cannot be conditionally included and is making hard for RNTA
    to integrated those changes.
    
    Changelog:
    [Internal] [Changed] - Remove import of `com.facebook.react.ReactSettingsExtension`
    
    Reviewed By: huntie
    
    Differential Revision: D58354443
    cortinico authored and facebook-github-bot committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8defb50 View commit details
    Browse the repository at this point in the history