Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][CI] Fix Nightlies for Android #44847

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

While migrating from CCI to GHA, we mistakenly set the ORG_GRADLE_PROJECT_reactNativeArchitectures wrongly. The result was that the nightly was building only 1 architecture for android instead of all of them.

This change fixes that, but asking GHA to build all the architectures when running nightlies

Changelog:

[Internal] - Build all the architectures for android when running nightlies

Test Plan:

Run a nightly from the branch and see it working

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 10, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-gha-nightlies branch 2 times, most recently from 5bde8c6 to 00e2f9d Compare June 10, 2024 07:19
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-gha-nightlies branch from 00e2f9d to 552e702 Compare June 10, 2024 07:19
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,248,885 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,454,650 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 6937c70
Branch: main

@cipolleschi
Copy link
Contributor Author

Can confirm that Nightly works now:
Screenshot_1718010438

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 10, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 9fa0764.

Copy link

This pull request was successfully merged by @cipolleschi in 9fa0764.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants