Implement NetworkRequestDelegate on iOS #44846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Design - `NetworkIO` is an object owned by the `HostAgent`, created by `HostTarget` where it is given a scoped executor. - `HostAgent` passes most handling of CDP `Network.loadNetworkResource` through `NetworkIO`. - `NetworkIO.loadNetworkResource` creates and holds a shared_ptr to a `Stream` representing a single resource load, and owning received headers and data. A reference is held in a map `streams_` until an error or it is closed with `IO.close`. `delegate.networkRequest` is called with the `stream`, which it retains for the lifetime of the request, and uses its methods to call back with headers, data and errors. - Callbacks for `IO.read` requests are held by the `Stream` until the incoming data is complete or enough data is available to fill the request (an implementation choice to optimise for fewest round trips). Any incoming data or error causes any pending requests to be rechecked. ## Unimplemented platforms - Platforms may optionally implement `HostTargetDelegate.networkRequest` (as of this diff, none do). If they don't we report a CDP "not implemented" error, similar to the status quo where it was unimplemented by the C++ agent. Differential Revision: D54309633
Summary: Implement `jsinspector_modern:: NetworkRequestDelegate` for iOS (bridge and bridgeless) to satisfy CDP `Network.loadNetworkResource` (etc) requests. Changelog: [iOS][Added] Debugger: Implement CDP methods for loading network resources through the debug target. Differential Revision: D54496969
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54496969 |
huntie
pushed a commit
to huntie/react-native
that referenced
this pull request
Aug 6, 2024
Summary: Pull Request resolved: facebook#44846 Implement the `networkRequest` method of `jsinspector_modern::HostTargetDelegate` for iOS (bridge and bridgeless) to satisfy CDP `Network.loadNetworkResource` (etc) requests. Changelog: [iOS][Added] Debugger: Implement CDP methods for loading network resources through the debug target. Reviewed By: huntie Differential Revision: D54496969
huntie
pushed a commit
to huntie/react-native
that referenced
this pull request
Aug 6, 2024
Summary: Pull Request resolved: facebook#44846 Implement the `networkRequest` method of `jsinspector_modern::HostTargetDelegate` for iOS (bridge and bridgeless) to satisfy CDP `Network.loadNetworkResource` (etc) requests. Changelog: [iOS][Added] Debugger: Implement CDP methods for loading network resources through the debug target. Reviewed By: huntie Differential Revision: D54496969
huntie
pushed a commit
to huntie/react-native
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: facebook#44846 Implement the `networkRequest` method of `jsinspector_modern::HostTargetDelegate` for iOS (bridge and bridgeless) to satisfy CDP `Network.loadNetworkResource` (etc) requests. Changelog: [iOS][Added] Debugger: Implement CDP methods for loading network resources through the debug target. Reviewed By: huntie Differential Revision: D54496969
|
This pull request has been merged in c720583. |
|
This pull request was successfully merged by @robhogan in c720583 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement
jsinspector_modern:: NetworkRequestDelegatefor iOS (bridge and bridgeless) to satisfy CDPNetwork.loadNetworkResource(etc) requests.Changelog:
[iOS][Added] Debugger: Implement CDP methods for loading network resources through the debug target.
Differential Revision: D54496969