Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] [.] - Mocks' argument clean up #44843

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Chore] [.] - Mocks' argument clean up #44843

wants to merge 3 commits into from

Conversation

12ya
Copy link

@12ya 12ya commented Jun 9, 2024 •
edited
Loading

…:getDeliveredNotifications function mock

Summary:

clean up mocks' unnecessary argument to avoid confusion

Changelog:

Pick one each for the category and type tags:

[GENERAL] [REMOVED] - remove unused arguments from mocks

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024 •
edited
Loading

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against b0ac72a

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 9, 2024
@12ya
chore: AsyncLocalStorage & ImageLoader & ImageViewManager & Libraries…
b889706 
…/NativeComponent/NativeComponentRegistry mocks cleanup
@12ya 12ya changed the title chore: remove unnecessary argument return in PushNotificationManager:… [Chore] [.] - Mocks' argument clean up Jun 9, 2024
@javache
Copy link
Member

javache commented Jun 10, 2024

Is there a lint rule warning against this? Otherwise, I'd be inclined to leave these here for clarity.

@12ya
Copy link
Author

12ya commented Jun 12, 2024 •
edited
Loading

Is there a lint rule warning against this? Otherwise, I'd be inclined to leave these here for clarity.
@javache,
thanks for pointing it out,
would this b0ac72a be a better solution?

@12ya 12ya closed this Jun 26, 2024
@12ya 12ya reopened this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@12ya @javache @facebook-github-bot